Re: [PATCH V8 1/2] PHY: Exynos: Add Exynos5250 SATA PHY driver

Jingoo Han
2014-02-25T05:25:36Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 1256 bytes --]

On Mon, 24 Feb 2014 19:26:44, Kishon Vijay Abraham I wrote:
> On Monday 24 February 2014 07:02 PM, Yuvaraj Kumar C D wrote:
> > This patch adds the SATA PHY driver for Exynos5250.Exynos5250 SATA
> > PHY comprises of CMU and TRSV blocks which are of I2C register Map.
> > So this patch also adds a i2c client driver, which is used configure
>
> We no longer have i2c client driver here.

Right.

> > the CMU and TRSV block of exynos5250 SATA PHY.
> >
> > This patch incorporates the generic PHY framework to deal with SATA
> > PHY.
>
> It should be rephrased to have *uses* generic PHY framework. However I feel we
> can do away with this line.

Right, "incorporates" is confusing.

> >
> > This patch depends on the below patch for the sata functionality
> > [1].ata: ahci_platform: Manage SATA PHY
> > by Roger Quadros <rogerq@xxxxxx>
>
> hasn't this patch merged yet?

Currently, this patch was queued into libata tree, for-next. [1]

[1] http://git.kernel.org/cgit/linux/kernel/git/tj/libata.git/commit/?h=for-next&id=21b5faeec229d4f70a7f60a7b0b065c98198f491

Best regards,
Jingoo Hanÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥