From: Corey Minyard <cminyard@mvista.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>, minyard@acm.org
Cc: OpenIPMI Developers <openipmi-developer@lists.sourceforge.net>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Russ Anderson <rja@sgi.com>,
Matthew Garrett <matthew.garrett@nebula.com>,
lenb@kernel.org, rjw@rjwysocki.net, linux-acpi@vger.kernel.org
Subject: Re: [PATCH 2/3] ipmi: Turn off all activity on an idle ipmi interface
Date: Mon, 24 Feb 2014 11:08:50 -0600 [thread overview]
Message-ID: <530B7CA2.2050700@mvista.com> (raw)
In-Reply-To: <20140224165738.GB26479@core.coreip.homeip.net>
On 02/24/2014 10:57 AM, Dmitry Torokhov wrote:
> On Sun, Feb 23, 2014 at 08:23:35PM -0600, minyard@acm.org wrote:
>> @@ -1194,7 +1223,17 @@ int ipmi_set_gets_events(ipmi_user_t user, int val)
>> INIT_LIST_HEAD(&msgs);
>>
>> spin_lock_irqsave(&intf->events_lock, flags);
>> - user->gets_events = val;
>> + if (user->gets_events == !!val)
>> + goto out;
>> +
>> + user->gets_events = !!val;
> Why not have val declared as bool and let compiler convert as needed?
>
> Thanks.
>
Because I've been programming in C since long before there was a bool
type, and I need to change the way I think. Fixed, thanks.
-core
next prev parent reply other threads:[~2014-02-24 17:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 2:23 [PATCH 0/3] ipmi: Cleanups for allowing IPMI support to always be "y" minyard
2014-02-24 2:23 ` [PATCH 1/3] ipmi: Turn off default probing of interfaces minyard
2014-02-24 16:53 ` Dmitry Torokhov
2014-02-24 16:55 ` Matthew Garrett
2014-02-24 16:57 ` Corey Minyard
2014-02-24 2:23 ` [PATCH 2/3] ipmi: Turn off all activity on an idle ipmi interface minyard
2014-02-24 16:57 ` Dmitry Torokhov
2014-02-24 17:08 ` Corey Minyard [this message]
2014-02-24 2:23 ` [PATCH 3/3] Change ACPI IPMI support to "default y" minyard
2014-02-24 12:43 ` [PATCH 0/3] ipmi: Cleanups for allowing IPMI support to always be "y" Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530B7CA2.2050700@mvista.com \
--to=cminyard@mvista.com \
--cc=dmitry.torokhov@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.garrett@nebula.com \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
--cc=rja@sgi.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox