From: James Smart <james.smart@emulex.com>
To: Daeseok Youn <daeseok.youn@gmail.com>
Cc: <JBottomley@parallels.com>, <linux-kernel@vger.kernel.org>,
<linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] [SCSI] lpfc 8.3.43: use NULL instead of 0 for pointer
Date: Mon, 24 Feb 2014 12:37:49 -0500 [thread overview]
Message-ID: <530B836D.6000508@emulex.com> (raw)
In-Reply-To: <1790992.BDi3De8mQ2@daeseok-laptop.cloud.net>
Acked-by: James Smart <james.smart@emulex.com>
-- james s
On 2/20/2014 8:10 PM, Daeseok Youn wrote:
> >From 9e7478f6e953fac5b2bef0f5abe76fe8dc9e59d1 Mon Sep 17 00:00:00 2001
> From: Daeseok Youn <daeseok.youn@gmail.com>
> Date: Fri, 21 Feb 2014 09:03:32 +0900
> Subject: [PATCH] [SCSI] lpfc 8.3.43: use NULL instead of 0 for pointer
>
> sparse says:
> drivers/scsi/lpfc/lpfc_sli.c:16547:37: warning:
> Using plain integer as NULL pointer
>
> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> ---
> drivers/scsi/lpfc/lpfc_sli.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c
> index 8f580fd..a218ecd 100644
> --- a/drivers/scsi/lpfc/lpfc_sli.c
> +++ b/drivers/scsi/lpfc/lpfc_sli.c
> @@ -16544,7 +16544,7 @@ lpfc_drain_txq(struct lpfc_hba *phba)
> {
> LIST_HEAD(completions);
> struct lpfc_sli_ring *pring = &phba->sli.ring[LPFC_ELS_RING];
> - struct lpfc_iocbq *piocbq = 0;
> + struct lpfc_iocbq *piocbq = NULL;
> unsigned long iflags = 0;
> char *fail_msg = NULL;
> struct lpfc_sglq *sglq;
prev parent reply other threads:[~2014-02-24 17:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 1:10 [PATCH] [SCSI] lpfc 8.3.43: use NULL instead of 0 for pointer Daeseok Youn
2014-02-24 17:37 ` James Smart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530B836D.6000508@emulex.com \
--to=james.smart@emulex.com \
--cc=JBottomley@parallels.com \
--cc=daeseok.youn@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox