From: John Stultz <john.stultz@linaro.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Prarit Bhargava <prarit@redhat.com>,
Richard Cochran <richardcochran@gmail.com>
Subject: Re: [PATCH] [RFC] time: Improve negative offset handling in timekeeping_inject_offset
Date: Mon, 24 Feb 2014 11:50:02 -0800 [thread overview]
Message-ID: <530BA26A.5070603@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.02.1402221058010.21251@ionos.tec.linutronix.de>
On 02/22/2014 02:01 AM, Thomas Gleixner wrote:
> On Fri, 21 Feb 2014, John Stultz wrote:
>> But yes, we can just leave it as is, and it is a bit academic. But
> To be honest, I was mostly arguing due to the academic nature. :)
>
> The important point is that we restrict it to -1e9 < tv_nsec <
> 1e9. The signed/unsigned combos are not that interesting as long as
> our internal helpers cope nicely with that.
And for this patch it does check abs(tv_nsec) is sane.
I still think the patch is a good idea, so I'll submit it again after
further testing. But if folks object, then I'll drop it.
thanks
-john
next prev parent reply other threads:[~2014-02-24 19:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 21:50 [PATCH] [RFC] time: Improve negative offset handling in timekeeping_inject_offset John Stultz
2014-02-21 22:54 ` Thomas Gleixner
2014-02-21 23:24 ` John Stultz
2014-02-22 10:01 ` Thomas Gleixner
2014-02-24 19:50 ` John Stultz [this message]
2014-02-25 9:14 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530BA26A.5070603@linaro.org \
--to=john.stultz@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=richardcochran@gmail.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox