From: Tom Rini <trini@ti.com>
To: Joe Perches <joe@perches.com>
Cc: Josh Triplett <josh@joshtriplett.org>,
<linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] checkpatch.pl: Add warning for new __packed additions
Date: Mon, 24 Feb 2014 17:20:20 -0500 [thread overview]
Message-ID: <530BC5A4.4060803@ti.com> (raw)
In-Reply-To: <1393279691.11020.69.camel@joe-AO722>
On 02/24/2014 05:08 PM, Joe Perches wrote:
> On Mon, 2014-02-24 at 17:04 -0500, Tom Rini wrote:
>> I've got this modified to a CHK and only for non-file usage. Anything
>> else we want to talk about before I repost?
>
> Probably not, but I'm still not convinced it's useful.
>
> Have you found a case where it's currently specified
> but not useful?
Well, U-Boot and the kernel both share the dubious to incorrect __packed
horror of cros_ec things (see include/linux/mfd/cros_ec_commands.h).
If this is really not seen as useful for the kernel, that's fine, I'll
drop it. I mainly did this for U-Boot where we do want a bit more loud
screaming going on when people add __packed to make sure it's for a good
reason. Wanted to be a good neighbor so to speak and see if upstream
wants it too.
--
Tom
next prev parent reply other threads:[~2014-02-24 22:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 20:38 [PATCH] checkpatch.pl: Add warning for new __packed additions Tom Rini
2014-02-24 21:00 ` Joe Perches
2014-02-24 21:11 ` Tom Rini
2014-02-24 21:28 ` Joe Perches
2014-02-24 21:52 ` Tom Rini
2014-02-24 22:02 ` Joe Perches
2014-02-24 22:04 ` Tom Rini
2014-02-24 22:08 ` Joe Perches
2014-02-24 22:20 ` Tom Rini [this message]
2014-02-24 22:31 ` Joe Perches
2014-02-24 22:43 ` Tom Rini
2014-02-25 5:23 ` Joe Perches
2014-02-25 12:30 ` Tom Rini
2014-02-26 22:04 ` Joe Perches
2014-02-27 20:33 ` Tom Rini
2014-02-25 8:56 ` Heiko Carstens
2014-02-24 21:31 ` josh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530BC5A4.4060803@ti.com \
--to=trini@ti.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox