From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752926AbaBXXeo (ORCPT ); Mon, 24 Feb 2014 18:34:44 -0500 Received: from mail-ee0-f54.google.com ([74.125.83.54]:55263 "EHLO mail-ee0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752446AbaBXXen (ORCPT ); Mon, 24 Feb 2014 18:34:43 -0500 Message-ID: <530BD70E.3000206@gmail.com> Date: Tue, 25 Feb 2014 00:34:38 +0100 From: Sebastian Hesselbarth User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 To: David Miller , f.fainelli@gmail.com CC: andrew@lunn.ch, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: phy: add suspend_halted module param References: <1393174719-20806-1-git-send-email-sebastian.hesselbarth@gmail.com> <20140224.180510.103916219115440711.davem@davemloft.net> In-Reply-To: <20140224.180510.103916219115440711.davem@davemloft.net> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/25/2014 12:05 AM, David Miller wrote: > From: Florian Fainelli > Date: Mon, 24 Feb 2014 10:20:10 -0800 > >> Hi Sebastian, >> >> 2014-02-23 8:58 GMT-08:00 Sebastian Hesselbarth >> : >>> commit 1211ce53077164e0d34641d0ca5fb4d4a7574498 >>> ("net: phy: resume/suspend PHYs on attach/detach") >>> introduced a feature to suspend PHYs when entering halted state. >>> >>> Unfortunately, not all bootloaders properly power-up PHYs on reset >>> and fail to access ethernet because the PHY is still powered down. >>> >>> Therefore, we add a boolean module parameter suspend_halted with >>> default value of true. Disabling that parameter prevents PHYs from >>> being suspended when entering halted state. >>> >>> Signed-off-by: Sebastian Hesselbarth >>> Reported-by: Andrew Lunn >>> --- >>> Andrew, can you please re-test if disabling the feature does work on >>> your board? I tried a bunch of mine, but none failed to power-up the >>> PHY in u-boot. >> >> Would be good to get Andrew's testing on this just to make sure it >> solves his problem. Otherwise: >> >> Acked-by: Florian Fainelli > > I disagree with using a module parameter for this. > > Figure out the devices that cannot do this properly, and add > an internal flag that this driver sets. Hmm, as it seems to be a bootloader issue, it will be quite impossible to determine if a board is affected or not. I am still trying to get any of my boards to mis-behave the same way to figure out what is really causing it. We do still have 2-3 weeks to find a proper fix, don't we? > Module parameters are terrible. Maybe. If you prefer, I can remove the module param and leave the sysfs entry? Sebastian