From: Behan Webster <behanw@converseincode.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>,
rob@landley.net, rdunlap@infradead.org, geert@linux-m68k.org
Cc: akpm@linux-foundation.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, "Jan-Simon Möller" <dl9pf@gmx.de>
Subject: Re: [PATCH] module: LLVMLinux: Fix section mismatch issues on alias usage
Date: Mon, 24 Feb 2014 18:33:54 -0800 [thread overview]
Message-ID: <530C0112.4070503@converseincode.com> (raw)
In-Reply-To: <53076BDE.5000205@windriver.com>
On 02/21/14 07:08, Paul Gortmaker wrote:
>> Attribute aliases don't inherit the link section name when compiled with clang.
>> As a result, the linking section needs to be explicitly specified when building
>> a module. This behavior is undefined in the standard which is why it differs from
>> compiler to compiler.
> But is there a good reason why clang doesn't inherit them in the
> interest of compatibility with gcc and existing code?
There is no reason other than it doesn't appear to be documented
behaviour anywhere that can be found. It seems like this use of an
aliased symbol inheriting attributes never came up before. Personally I
think the kernel code pushes compilers harder than most other code bases. :)
Having said that, it seems since we first started needing this patch to
build the kernel with clang, this issue may have been fixed in the most
recent updates to clang in the last few weeks. I've been testing with
the latest released version of clang v3.4 (since clang recently when
through a merge window of their own) which still requires this patch.
However in appears that this issue may now have been fixed in mainline
clang. I'll do some more testing to verify and get back to this thread.
> I know we've seen the faceless entity "PaX Team" before, but can we
> please not make it worse by adding a bunch of other non standard tag
> line formats? And ideally have a real human name for the author too.
Fair enough. Will fix and resubmit if the patch proves to still be
necessary.
Thanks for the input,
Behan
--
Behan Webster
behanw@converseincode.com
prev parent reply other threads:[~2014-02-25 2:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 4:28 [PATCH] module: LLVMLinux: Fix section mismatch issues on alias usage behanw
2014-02-21 15:08 ` Paul Gortmaker
2014-02-25 2:33 ` Behan Webster [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530C0112.4070503@converseincode.com \
--to=behanw@converseincode.com \
--cc=akpm@linux-foundation.org \
--cc=dl9pf@gmx.de \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=rdunlap@infradead.org \
--cc=rob@landley.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox