From: Jaehoon Chung <jh80.chung@samsung.com>
To: Felipe Balbi <balbi@ti.com>, chris@printf.net
Cc: jh80.chung@samsung.com, tgih.jun@samsung.com,
linux-mmc@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH] mmc: host: dw: fix possible build error
Date: Wed, 26 Feb 2014 07:03:59 +0900 [thread overview]
Message-ID: <530D134F.5090403@samsung.com> (raw)
In-Reply-To: <1393340264-22687-1-git-send-email-balbi@ti.com>
Hi, Felipe.
When you send the patch related with dw_mmc controller, could you use the prefix "mmc: dw_mmc:"?
"mmc: dw_mmc: fix possible build error"
Acked-by: Jaehoon Chung <jh80.chung@samsung.com>
Best Regards,
Jaehoon Chung
On 02/25/2014 11:57 PM, Felipe Balbi wrote:
> Fix the following build errors:
>
> drivers/mmc/host/dw_mmc-k3.c: In function ‘dw_mci_k3_suspend’:
> drivers/mmc/host/dw_mmc-k3.c:58:2: error: implicit declaration of
> function ‘dw_mci_suspend’ [-Werror=implicit-function-declaration]
> ret = dw_mci_suspend(host);
> ^
> drivers/mmc/host/dw_mmc-k3.c: In function ‘dw_mci_k3_resume’:
> drivers/mmc/host/dw_mmc-k3.c:76:2: error: implicit declaration of
> function ‘dw_mci_resume’ [-Werror=implicit-function-declaration]
> return dw_mci_resume(host);
> ^
> drivers/mmc/host/dw_mmc-k3.c: At top level:
> drivers/mmc/host/dw_mmc-k3.c:53:12: warning: ‘dw_mci_k3_suspend’ defined
> but not used [-Wunused-function]
> static int dw_mci_k3_suspend(struct device *dev)
> ^
> drivers/mmc/host/dw_mmc-k3.c:65:12: warning: ‘dw_mci_k3_resume’ defined
> but not used [-Wunused-function]
> static int dw_mci_k3_resume(struct device *dev)
> ^
>
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
> drivers/mmc/host/dw_mmc-k3.c | 2 ++
> drivers/mmc/host/dw_mmc.h | 2 +-
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/dw_mmc-k3.c b/drivers/mmc/host/dw_mmc-k3.c
> index f567c21..650f9cc 100644
> --- a/drivers/mmc/host/dw_mmc-k3.c
> +++ b/drivers/mmc/host/dw_mmc-k3.c
> @@ -50,6 +50,7 @@ static int dw_mci_k3_probe(struct platform_device *pdev)
> return dw_mci_pltfm_register(pdev, drv_data);
> }
>
> +#ifdef CONFIG_PM_SLEEP
> static int dw_mci_k3_suspend(struct device *dev)
> {
> struct dw_mci *host = dev_get_drvdata(dev);
> @@ -75,6 +76,7 @@ static int dw_mci_k3_resume(struct device *dev)
>
> return dw_mci_resume(host);
> }
> +#endif /* CONFIG_PM_SLEEP */
>
> static SIMPLE_DEV_PM_OPS(dw_mci_k3_pmops, dw_mci_k3_suspend, dw_mci_k3_resume);
>
> diff --git a/drivers/mmc/host/dw_mmc.h b/drivers/mmc/host/dw_mmc.h
> index 6bf24ab..1f7a745 100644
> --- a/drivers/mmc/host/dw_mmc.h
> +++ b/drivers/mmc/host/dw_mmc.h
> @@ -185,7 +185,7 @@
>
> extern int dw_mci_probe(struct dw_mci *host);
> extern void dw_mci_remove(struct dw_mci *host);
> -#ifdef CONFIG_PM
> +#ifdef CONFIG_PM_SLEEP
> extern int dw_mci_suspend(struct dw_mci *host);
> extern int dw_mci_resume(struct dw_mci *host);
> #endif
>
next prev parent reply other threads:[~2014-02-25 22:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 14:57 [PATCH] mmc: host: dw: fix possible build error Felipe Balbi
2014-02-25 22:03 ` Jaehoon Chung [this message]
2014-03-03 18:06 ` Felipe Balbi
2014-03-03 19:01 ` Chris Ball
2014-03-03 19:05 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530D134F.5090403@samsung.com \
--to=jh80.chung@samsung.com \
--cc=balbi@ti.com \
--cc=chris@printf.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox