* [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf
@ 2014-02-23 1:19 Satoru Takeuchi
2014-02-24 14:30 ` Steven Rostedt
0 siblings, 1 reply; 6+ messages in thread
From: Satoru Takeuchi @ 2014-02-23 1:19 UTC (permalink / raw)
To: linux-kernel; +Cc: Steven Rostedt
From: Satoru Takeuchi <satoru.takeuchi@gmail.com>
As mentioned at commit 5a5d8e48449, we can't terminate 'virsh console'
with the default signal(INT). So it's better to set CLOSE_CONSOLE_SIGNAL
in the kvm.conf.
Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
---
tools/testing/ktest/examples/kvm.conf | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/testing/ktest/examples/kvm.conf b/tools/testing/ktest/examples/kvm.conf
index 831c7c5..40356f7 100644
--- a/tools/testing/ktest/examples/kvm.conf
+++ b/tools/testing/ktest/examples/kvm.conf
@@ -10,6 +10,10 @@ MACHINE = Guest
# Use virsh to read the serial console of the guest
CONSOLE = virsh console ${MACHINE}
+# Use SIGILL to terminate virsh console. We can't kill virsh console
+# by the default signal, SIGINT.
+CLOSE_CONSOLE_SIGNAL = KILL
+
#*************************************#
# This part is the same as test.conf #
#*************************************#
--
1.8.4.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf
2014-02-23 1:19 [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf Satoru Takeuchi
@ 2014-02-24 14:30 ` Steven Rostedt
2014-02-26 2:21 ` MUNEDA Takahiro
0 siblings, 1 reply; 6+ messages in thread
From: Steven Rostedt @ 2014-02-24 14:30 UTC (permalink / raw)
To: Satoru Takeuchi; +Cc: linux-kernel
On Sun, 23 Feb 2014 10:19:28 +0900
Satoru Takeuchi <satoru.takeuchi@gmail.com> wrote:
> From: Satoru Takeuchi <satoru.takeuchi@gmail.com>
>
> As mentioned at commit 5a5d8e48449, we can't terminate 'virsh console'
> with the default signal(INT). So it's better to set CLOSE_CONSOLE_SIGNAL
> in the kvm.conf.
>
> Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> ---
> tools/testing/ktest/examples/kvm.conf | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tools/testing/ktest/examples/kvm.conf b/tools/testing/ktest/examples/kvm.conf
> index 831c7c5..40356f7 100644
> --- a/tools/testing/ktest/examples/kvm.conf
> +++ b/tools/testing/ktest/examples/kvm.conf
> @@ -10,6 +10,10 @@ MACHINE = Guest
> # Use virsh to read the serial console of the guest
> CONSOLE = virsh console ${MACHINE}
>
> +# Use SIGILL to terminate virsh console. We can't kill virsh console
> +# by the default signal, SIGINT.
> +CLOSE_CONSOLE_SIGNAL = KILL
> +
Thanks, I'll add this to my 3.15 queue.
-- Steve
> #*************************************#
> # This part is the same as test.conf #
> #*************************************#
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf
2014-02-24 14:30 ` Steven Rostedt
@ 2014-02-26 2:21 ` MUNEDA Takahiro
2014-02-26 11:43 ` Satoru Takeuchi
2014-02-26 20:29 ` Steven Rostedt
0 siblings, 2 replies; 6+ messages in thread
From: MUNEDA Takahiro @ 2014-02-26 2:21 UTC (permalink / raw)
To: Steven Rostedt, Satoru Takeuchi; +Cc: muneda.takahiro, linux-kernel
On Mon, 24 Feb 2014 09:30:39 -0500,
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Sun, 23 Feb 2014 10:19:28 +0900
> Satoru Takeuchi <satoru.takeuchi@gmail.com> wrote:
>
>> From: Satoru Takeuchi <satoru.takeuchi@gmail.com>
>>
>> As mentioned at commit 5a5d8e48449, we can't terminate 'virsh console'
>> with the default signal(INT). So it's better to set CLOSE_CONSOLE_SIGNAL
>> in the kvm.conf.
>>
>> Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
>> Cc: Steven Rostedt <rostedt@goodmis.org>
>> ---
>> tools/testing/ktest/examples/kvm.conf | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/tools/testing/ktest/examples/kvm.conf b/tools/testing/ktest/examples/kvm.conf
>> index 831c7c5..40356f7 100644
>> --- a/tools/testing/ktest/examples/kvm.conf
>> +++ b/tools/testing/ktest/examples/kvm.conf
>> @@ -10,6 +10,10 @@ MACHINE = Guest
>> # Use virsh to read the serial console of the guest
>> CONSOLE = virsh console ${MACHINE}
>>
>> +# Use SIGILL to terminate virsh console. We can't kill virsh console
>> +# by the default signal, SIGINT.
>> +CLOSE_CONSOLE_SIGNAL = KILL
>> +
>
> Thanks, I'll add this to my 3.15 queue.
Hmm, it seems that we need a following patch as well.
Or, please merge with the orignal patch.
Thanks,
Takahiro
======================================================================
From a1c7b948c47a6ea7b74225bf5698fdfb7199726a Mon Sep 17 00:00:00 2001
From: MUNEDA Takahiro <muneda.takahiro@jp.fujitsu.com>
Date: Tue, 25 Feb 2014 15:32:35 -0500
Subject: [PATCH] ktest: Fixes a trivial typo
Signed-off-by: MUNEDA Takahiro <muneda.takahiro@jp.fujitsu.com>
Cc: Satoru Takeuchi <satoru.takeuchi@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
---
tools/testing/ktest/examples/kvm.conf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/ktest/examples/kvm.conf b/tools/testing/ktest/examples/kvm.conf
index 40356f7..fbc134f 100644
--- a/tools/testing/ktest/examples/kvm.conf
+++ b/tools/testing/ktest/examples/kvm.conf
@@ -10,7 +10,7 @@ MACHINE = Guest
# Use virsh to read the serial console of the guest
CONSOLE = virsh console ${MACHINE}
-# Use SIGILL to terminate virsh console. We can't kill virsh console
+# Use SIGKILL to terminate virsh console. We can't kill virsh console
# by the default signal, SIGINT.
CLOSE_CONSOLE_SIGNAL = KILL
--
1.8.3.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf
2014-02-26 2:21 ` MUNEDA Takahiro
@ 2014-02-26 11:43 ` Satoru Takeuchi
2014-02-26 13:43 ` Steven Rostedt
2014-02-26 20:29 ` Steven Rostedt
1 sibling, 1 reply; 6+ messages in thread
From: Satoru Takeuchi @ 2014-02-26 11:43 UTC (permalink / raw)
To: MUNEDA Takahiro; +Cc: Steven Rostedt, Satoru Takeuchi, linux-kernel
At Tue, 25 Feb 2014 21:21:18 -0500,
MUNEDA Takahiro wrote:
>
> On Mon, 24 Feb 2014 09:30:39 -0500,
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > On Sun, 23 Feb 2014 10:19:28 +0900
> > Satoru Takeuchi <satoru.takeuchi@gmail.com> wrote:
> >
> >> From: Satoru Takeuchi <satoru.takeuchi@gmail.com>
> >>
> >> As mentioned at commit 5a5d8e48449, we can't terminate 'virsh console'
> >> with the default signal(INT). So it's better to set CLOSE_CONSOLE_SIGNAL
> >> in the kvm.conf.
> >>
> >> Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
> >> Cc: Steven Rostedt <rostedt@goodmis.org>
> >> ---
> >> tools/testing/ktest/examples/kvm.conf | 4 ++++
> >> 1 file changed, 4 insertions(+)
> >>
> >> diff --git a/tools/testing/ktest/examples/kvm.conf b/tools/testing/ktest/examples/kvm.conf
> >> index 831c7c5..40356f7 100644
> >> --- a/tools/testing/ktest/examples/kvm.conf
> >> +++ b/tools/testing/ktest/examples/kvm.conf
> >> @@ -10,6 +10,10 @@ MACHINE = Guest
> >> # Use virsh to read the serial console of the guest
> >> CONSOLE = virsh console ${MACHINE}
> >>
> >> +# Use SIGILL to terminate virsh console. We can't kill virsh console
> >> +# by the default signal, SIGINT.
> >> +CLOSE_CONSOLE_SIGNAL = KILL
> >> +
> >
> > Thanks, I'll add this to my 3.15 queue.
>
> Hmm, it seems that we need a following patch as well.
> Or, please merge with the orignal patch.
>
> Thanks,
> Takahiro
>
> ======================================================================
> From a1c7b948c47a6ea7b74225bf5698fdfb7199726a Mon Sep 17 00:00:00 2001
> From: MUNEDA Takahiro <muneda.takahiro@jp.fujitsu.com>
> Date: Tue, 25 Feb 2014 15:32:35 -0500
> Subject: [PATCH] ktest: Fixes a trivial typo
>
> Signed-off-by: MUNEDA Takahiro <muneda.takahiro@jp.fujitsu.com>
> Cc: Satoru Takeuchi <satoru.takeuchi@gmail.com>
> Cc: Steven Rostedt <rostedt@goodmis.org>
>
> ---
> tools/testing/ktest/examples/kvm.conf | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/ktest/examples/kvm.conf b/tools/testing/ktest/examples/kvm.conf
> index 40356f7..fbc134f 100644
> --- a/tools/testing/ktest/examples/kvm.conf
> +++ b/tools/testing/ktest/examples/kvm.conf
> @@ -10,7 +10,7 @@ MACHINE = Guest
> # Use virsh to read the serial console of the guest
> CONSOLE = virsh console ${MACHINE}
> -# Use SIGILL to terminate virsh console. We can't kill virsh console
> +# Use SIGKILL to terminate virsh console. We can't kill virsh console
Oops, it's a completely the different signal. Thanks Takahiro.
Satoru
> # by the default signal, SIGINT.
> CLOSE_CONSOLE_SIGNAL = KILL
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf
2014-02-26 11:43 ` Satoru Takeuchi
@ 2014-02-26 13:43 ` Steven Rostedt
0 siblings, 0 replies; 6+ messages in thread
From: Steven Rostedt @ 2014-02-26 13:43 UTC (permalink / raw)
To: Satoru Takeuchi; +Cc: MUNEDA Takahiro, linux-kernel
On Wed, 26 Feb 2014 20:43:16 +0900
Satoru Takeuchi <satoru.takeuchi@gmail.com> wrote:
> > -# Use SIGILL to terminate virsh console. We can't kill virsh console
> > +# Use SIGKILL to terminate virsh console. We can't kill virsh console
>
> Oops, it's a completely the different signal. Thanks Takahiro.
Please be careful...
That one letter is the difference between the "Beastie Boys" and "007"
Sending the Beastie Boys out to serve for Her Majesty's Secret Service
would be a disaster.
http://en.wikipedia.org/wiki/Licensed_to_Ill
http://en.wikipedia.org/wiki/Licensed_to_Kill_(1965_film)
-- Steve
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf
2014-02-26 2:21 ` MUNEDA Takahiro
2014-02-26 11:43 ` Satoru Takeuchi
@ 2014-02-26 20:29 ` Steven Rostedt
1 sibling, 0 replies; 6+ messages in thread
From: Steven Rostedt @ 2014-02-26 20:29 UTC (permalink / raw)
To: MUNEDA Takahiro; +Cc: Satoru Takeuchi, linux-kernel
On Tue, 25 Feb 2014 21:21:18 -0500
MUNEDA Takahiro <muneda.takahiro@jp.fujitsu.com> wrote:
> Hmm, it seems that we need a following patch as well.
> Or, please merge with the orignal patch.
I folded this fix in, here's the final:
>From 62183dcac539a14ed0a820b8392db353d72a7d7e Mon Sep 17 00:00:00 2001
From: Satoru Takeuchi <satoru.takeuchi@gmail.com>
Date: Sun, 23 Feb 2014 10:19:28 +0900
Subject: [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf
As mentioned at commit 5a5d8e48449, we can't terminate 'virsh console'
with the default signal(INT). So it's better to set CLOSE_CONSOLE_SIGNAL
in the kvm.conf.
Link: http://lkml.kernel.org/r/8738jatylb.wl%satoru.takeuchi@gmail.com
Signed-off-by: Satoru Takeuchi <satoru.takeuchi@gmail.com>
[ Typo fixed by ]
Signed-off-by: MUNEDA Takahiro <muneda.takahiro@jp.fujitsu.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
tools/testing/ktest/examples/kvm.conf | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/testing/ktest/examples/kvm.conf b/tools/testing/ktest/examples/kvm.conf
index 831c7c5..fbc134f 100644
--- a/tools/testing/ktest/examples/kvm.conf
+++ b/tools/testing/ktest/examples/kvm.conf
@@ -10,6 +10,10 @@ MACHINE = Guest
# Use virsh to read the serial console of the guest
CONSOLE = virsh console ${MACHINE}
+# Use SIGKILL to terminate virsh console. We can't kill virsh console
+# by the default signal, SIGINT.
+CLOSE_CONSOLE_SIGNAL = KILL
+
#*************************************#
# This part is the same as test.conf #
#*************************************#
--
1.8.5.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-26 20:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-23 1:19 [PATCH] ktest: Set CLOSE_CONSOLE_SIGNAL in the kvm.conf Satoru Takeuchi
2014-02-24 14:30 ` Steven Rostedt
2014-02-26 2:21 ` MUNEDA Takahiro
2014-02-26 11:43 ` Satoru Takeuchi
2014-02-26 13:43 ` Steven Rostedt
2014-02-26 20:29 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox