From: Guenter Roeck <linux@roeck-us.net>
To: Greg KH <gregkh@linuxfoundation.org>, "H. Peter Anvin" <hpa@zytor.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: The sheer number of sparse warnings in the kernel
Date: Thu, 27 Feb 2014 02:11:56 -0800 [thread overview]
Message-ID: <530F0F6C.4040401@roeck-us.net> (raw)
In-Reply-To: <20140227013424.GA9991@kroah.com>
>> So getting this to the point where it is genuinely useful and can be
>> made a ubiquitous part of the Linux development process is going to take
>> more work and probably involve improvements to sparse so we can indicate
>> in the kernel sources when something is okay or removing completely
>> bogus warnings, and so on.
>
> Yes, for some areas of the kernel it will take some work, but for
> others, sparse works really well. As an example, building all of
Works quite nicely for me. I run both spatch and smatch on drivers/hwmon
and (partially) on drivers/watchdog. There is only one (false) warning
in hwmon from spatch, plus about a dozen smatch warnings. I find it very
valuable; even if warnings are false positives they often point to
less than perfect code.
I filter out some noise from smatch, but at least so far I did not have
to do any filtering for spatch.
Guenter
next prev parent reply other threads:[~2014-02-27 10:12 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 22:49 The sheer number of sparse warnings in the kernel H. Peter Anvin
2014-02-26 23:25 ` Borislav Petkov
2014-02-27 8:27 ` Richard Weinberger
2014-02-26 23:28 ` Greg KH
2014-02-26 23:29 ` Greg KH
2014-02-26 23:31 ` H. Peter Anvin
2014-02-26 23:37 ` H. Peter Anvin
2014-02-27 1:19 ` Josh Boyer
2014-02-27 1:21 ` H. Peter Anvin
2014-03-04 23:13 ` Valdis.Kletnieks
2014-02-27 0:11 ` H. Peter Anvin
2014-02-27 1:34 ` Greg KH
2014-02-27 2:09 ` Joe Perches
2014-02-27 3:15 ` Dave Jones
2014-02-27 4:32 ` Greg KH
2014-02-27 10:11 ` Guenter Roeck [this message]
2014-02-27 1:52 ` Peter Hurley
2014-02-27 4:19 ` H. Peter Anvin
2014-02-27 4:31 ` Greg KH
2014-02-27 9:22 ` Geert Uytterhoeven
2014-02-27 0:48 ` Joe Perches
2014-02-27 0:51 ` H. Peter Anvin
2014-02-27 1:06 ` Joe Perches
2014-02-27 1:33 ` [PATCH] err.h: Use bool for IS_ERR and IS_ERR_OR_NULL Joe Perches
2014-02-27 2:03 ` [PATCH] sparse: Allow override of sizeof(bool) warning Joe Perches
2014-02-27 2:08 ` [RFC PATCH] Makefile: sparse - don't check sizeof(bool) Joe Perches
2014-02-27 2:28 ` [PATCH] sparse: Allow override of sizeof(bool) warning Josh Triplett
2014-02-27 2:53 ` [PATCH V2] " Joe Perches
2014-02-27 2:58 ` Josh Triplett
2014-02-27 3:19 ` [PATCH V3] " Joe Perches
2014-02-27 3:29 ` [PATCH V2] " H. Peter Anvin
2014-02-27 3:38 ` Joe Perches
2014-02-27 3:42 ` H. Peter Anvin
2014-02-27 8:25 ` Borislav Petkov
2014-02-27 15:10 ` H. Peter Anvin
2014-02-27 15:24 ` Theodore Ts'o
2014-02-27 15:48 ` H. Peter Anvin
2014-02-27 16:01 ` Borislav Petkov
2014-02-27 16:10 ` Dan Carpenter
2014-02-27 16:52 ` H. Peter Anvin
2014-02-27 17:06 ` James Hogan
2014-02-27 4:00 ` Ben Pfaff
2014-02-27 4:19 ` H. Peter Anvin
2014-02-27 4:26 ` Ben Pfaff
2014-02-27 4:32 ` H. Peter Anvin
2014-02-27 20:22 ` Christopher Li
2014-02-27 20:26 ` H. Peter Anvin
2014-02-27 20:39 ` Joe Perches
2014-02-27 20:55 ` Christopher Li
2014-02-27 21:49 ` Joe Perches
2014-02-27 20:44 ` Christopher Li
2014-02-27 21:00 ` Joe Perches
2014-02-27 21:03 ` Christopher Li
2014-02-27 21:41 ` Christopher Li
2014-02-27 9:56 ` The sheer number of sparse warnings in the kernel Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530F0F6C.4040401@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox