linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: Rashika Kheria <rashika.kheria@gmail.com>
Cc: <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Toshi Kani <toshi.kani@hp.com>,
	David Rientjes <rientjes@google.com>,
	Chen Gong <gong.chen@linux.intel.com>,
	Kevin Hao <haokexin@gmail.com>, <josh@joshtriplett.org>
Subject: Re: [PATCH 04/46] kernel: Mark function as static in kernel/resource.c
Date: Thu, 27 Feb 2014 21:14:01 +0900	[thread overview]
Message-ID: <530F2C09.2040500@jp.fujitsu.com> (raw)
In-Reply-To: <c216e1f98b80cff1736617fbf1474ea4dbaa4b4f.1393493276.git.rashika.kheria@gmail.com>

(2014/02/27 20:14), Rashika Kheria wrote:
> Mark function as static in kernel/resource.c because it is not used
> outside this file.
>
> This eliminates the following warning in kernel/resource.c:
> kernel/resource.c:518:5: warning: no previous prototype for ‘reallocate_resource’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <rashika.kheria@gmail.com>
> Reviewed-by: Josh Triplett <josh@joshtriplett.org>
> ---

Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>

Thanks,
Yasuaki Ishimatsu

>   kernel/resource.c |    6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/resource.c b/kernel/resource.c
> index 3f285dc..ede7db2 100644
> --- a/kernel/resource.c
> +++ b/kernel/resource.c
> @@ -515,9 +515,9 @@ static int find_resource(struct resource *root, struct resource *new,
>    * @newsize: new size of the resource descriptor
>    * @constraint: the size and alignment constraints to be met.
>    */
> -int reallocate_resource(struct resource *root, struct resource *old,
> -			resource_size_t newsize,
> -			struct resource_constraint  *constraint)
> +static int reallocate_resource(struct resource *root, struct resource *old,
> +			      resource_size_t newsize,
> +			      struct resource_constraint  *constraint)
>   {
>   	int err=0;
>   	struct resource new = *old;
>



  reply	other threads:[~2014-02-27 12:14 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-27 11:08 [PATCH 01/46] kernel: Move prototype declaration to header file include/linux/thread_info.h Rashika Kheria
2014-02-27 11:08 ` [PATCH 02/46] kernel: Add prototype definition to include/linux/kernel.h Rashika Kheria
2014-02-27 16:32   ` Steven Rostedt
2014-02-27 16:43     ` Josh Triplett
2014-02-27 17:04       ` Steven Rostedt
2014-02-27 11:12 ` [PATCH 03/46] kernel: Move prototype declaration to header file include/linux/cpu.h Rashika Kheria
2014-02-27 15:04   ` Toshi Kani
2014-02-27 16:20     ` Josh Triplett
2014-02-27 11:14 ` [PATCH 04/46] kernel: Mark function as static in kernel/resource.c Rashika Kheria
2014-02-27 12:14   ` Yasuaki Ishimatsu [this message]
2014-02-27 15:06   ` Toshi Kani
2014-02-27 11:29 ` [PATCH 05/46] kernel: Include appropriate header file in kernel/signal.c Rashika Kheria
2014-02-27 16:14   ` Oleg Nesterov
2014-02-27 11:30 ` [PATCH 06/46] kernel: Include appropriate header file in kernel/debug/kdb/kdb_keyboard.c Rashika Kheria
2014-02-27 11:32 ` [PATCH 07/46] kernel: Mark functions as static and remove unused function in events/core.c Rashika Kheria
2014-02-27 11:32 ` [PATCH 08/46] kernel: MOve prototype declaration to header file include/linux/perf_event.h Rashika Kheria
2014-02-27 11:54   ` Peter Zijlstra
2014-02-27 15:51     ` Josh Triplett
2014-02-27 19:23       ` Peter Zijlstra
2014-02-27 22:55         ` josh
2014-02-28 11:40           ` Peter Zijlstra
2014-02-27 11:35 ` [PATCH 09/46] kernel: Move prototype declaration to header file include/linux/hw_breakpoint.h Rashika Kheria
2014-02-27 11:36 ` [PATCH 10/46] kernel: Mark function as static in events/hw_breakpoint.c Rashika Kheria
2014-02-27 11:39 ` [PATCH 11/46] kernel: Add prototype declaration in kernel/gcov/base.c Rashika Kheria
2014-02-28  9:39   ` Peter Oberparleiter
2014-02-27 11:40 ` [PATCH 12/46] kernel: Include appropriate header file in kernel/irq/irqdomain.c Rashika Kheria
2014-02-27 12:33   ` [tip:irq/urgent] genirq: Include missing header file in irqdomain.c tip-bot for Rashika Kheria
2014-02-27 11:41 ` [PATCH 13/46] kernel: Move prototype declaration to header file kernel/locking/lockdep_internals.h Rashika Kheria
2014-02-27 11:43 ` [PATCH 14/46] kernel: Move prototype declaration to header file kernel/power/power.h Rashika Kheria
2014-02-28 13:21   ` Pavel Machek
2014-02-27 11:45 ` [PATCH 15/46] kernel: Include appropriate header file in kernel/power/wakelock.c Rashika Kheria
2014-02-27 11:46 ` [PATCH 16/46] kernel: Mark function as static in kernel/rcu/torture.c Rashika Kheria
2014-02-27 16:25   ` Paul E. McKenney
2014-02-27 11:48 ` [PATCH 17/46] kernel: Move prototype declaration to appropriate header file from kernel/stop_machine.c Rashika Kheria
2014-02-27 11:50 ` [PATCH 18/46] kernel: Mark functions as static in sched/fair.c Rashika Kheria
2014-02-27 11:58   ` Peter Zijlstra
2014-02-27 16:03     ` Josh Triplett
2014-02-27 19:24       ` Peter Zijlstra
2014-02-27 23:09         ` josh
2014-02-28  8:58           ` Peter Zijlstra
2014-02-27 11:52 ` [PATCH 19/46] kernel: Include appropriate header file in locking/rtmutex-tester.c Rashika Kheria
2014-02-27 11:53 ` [PATCH 20/46] kernel: Move prototype declaration to header file sched/sched.h from sched/core.c Rashika Kheria
2014-02-27 11:54 ` [PATCH 21/46] kernel: Mark function as static in sched/deadline.c Rashika Kheria
2014-02-27 11:55 ` [PATCH 22/46] kernel: Include appropriate header file in time/timekeeping_debug.c Rashika Kheria
2014-03-03  7:28   ` John Stultz
2014-02-27 11:57 ` [PATCH 23/46] kernel: Mark function as static in trace/ftrace.c Rashika Kheria
2014-02-27 16:34   ` Steven Rostedt
2014-02-27 12:01 ` [PATCH 24/46] kernel: Mark function as static in kernel/trace/ftrace.c and remove stub declaration from header file include/linux/ftrace.h Rashika Kheria
2014-02-27 16:18   ` Josh Triplett
2014-02-27 16:39   ` Steven Rostedt
2014-02-27 12:02 ` [PATCH 25/46] kernel: Add prototype declaration to " Rashika Kheria
2014-02-27 19:37   ` Steven Rostedt
2014-02-27 22:48     ` josh
2014-02-27 12:03 ` [PATCH 26/46] kernel: Mark functions as static in kernel/trace/trace.c Rashika Kheria
2014-02-27 19:42   ` Steven Rostedt
2014-02-27 12:06 ` [PATCH 27/46] kernel: Mark function as static in kernel/trace/trace_selftest.c Rashika Kheria
2014-02-27 19:54   ` Steven Rostedt
2014-02-27 12:08 ` [PATCH 28/46] kernel: Add prototype declaration to header file linux/ftrace.h Rashika Kheria
2014-02-27 19:56   ` Steven Rostedt
2014-02-27 12:10 ` [PATCH 29/46] kernel: Mark functions as static in trace/trace_functions_graph.c Rashika Kheria
2014-02-27 19:57   ` Steven Rostedt
2014-02-27 12:12 ` [PATCH 30/46] kernel: Add prototype declaration to header file include/linux/smp.h Rashika Kheria
2014-02-27 12:13 ` [PATCH 31/46] kernel: Mark function as static in kernel/module.c Rashika Kheria
2014-02-27 12:14 ` [PATCH 32/46] kernel: Add prototype declaration to header file include/linux/module.h Rashika Kheria
2014-02-27 12:16 ` [PATCH 33/46] kernel: Add prototype declaration to header file include/linux/compat.h Rashika Kheria
2014-02-27 12:17 ` [PATCH 34/46] kernel: Include appropriate header file in hung_task.c Rashika Kheria
2014-02-27 12:20 ` [PATCH 35/46] kernel: Mark function as static in kernel/seccomp.c Rashika Kheria
2014-02-27 15:33   ` Kees Cook
2014-02-27 15:48     ` Will Drewry
2014-02-28  2:53   ` James Morris
2014-02-27 12:20 ` [PATCH 36/46] kernel: Mark functions as static in kernel/tracepoint.c Rashika Kheria
2014-02-27 13:40   ` Mathieu Desnoyers
2014-02-27 12:22 ` [PATCH 37/46] kernel: Include appropriate header file in tracepoint.c Rashika Kheria
2014-02-27 13:37   ` Mathieu Desnoyers
2014-02-27 12:23 ` [PATCH 38/46] kernel: Include appropriate header file in kernel/elfcore.c Rashika Kheria
2014-02-27 12:25 ` [PATCH 39/46] kernel: Add prototype declaration to header file include/linux/irq_work.h Rashika Kheria
2014-02-27 12:28 ` [PATCH 40/46] kernel: Include appropriate header file in kernel/sched/core.c Rashika Kheria
2014-02-27 12:29 ` [PATCH 41/46] kernel: Mark functions as static in sched/core.c Rashika Kheria
2014-02-27 12:31 ` [PATCH 42/46] kernel: Add prototype declaration to appropriate header file include/linux/sched.h Rashika Kheria
2014-02-27 12:33 ` [PATCH 43/46] kernel: Add prototype declaration to header file kernel/sched/sched.h Rashika Kheria
2014-02-27 12:34 ` [PATCH 44/46] kernel: Move prototype declaration to header file kernel/sched/sched.h from kernel/sched/rt.c Rashika Kheria
2014-02-27 12:36 ` [PATCH 45/46] kernel: Move prototype declaration to header file include/linux/sched.h from init/main.c Rashika Kheria
2014-02-27 12:37 ` [PATCH 46/46] kernel: Add prototype declaration to header file include/linux/sched.h Rashika Kheria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=530F2C09.2040500@jp.fujitsu.com \
    --to=isimatu.yasuaki@jp.fujitsu.com \
    --cc=akpm@linux-foundation.org \
    --cc=gong.chen@linux.intel.com \
    --cc=haokexin@gmail.com \
    --cc=josh@joshtriplett.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rashika.kheria@gmail.com \
    --cc=rientjes@google.com \
    --cc=toshi.kani@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).