From: Tom Rini <trini@ti.com>
To: Joe Perches <joe@perches.com>
Cc: Josh Triplett <josh@joshtriplett.org>,
<linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] checkpatch.pl: Add warning for new __packed additions
Date: Thu, 27 Feb 2014 15:33:03 -0500 [thread overview]
Message-ID: <530FA0FF.9010202@ti.com> (raw)
In-Reply-To: <1393452256.24588.5.camel@joe-AO722>
On 02/26/2014 05:04 PM, Joe Perches wrote:
> On Tue, 2014-02-25 at 07:30 -0500, Tom Rini wrote:
>> The only intentional differences we have today are adding debug/printf
>> to the list of log functions
>
> That seems fine and trivial to keep current.
Agreed,
>> and pointing people at boards.cfg not
>> CHECKPATCH in MAINTAINERS,
>
> That seems wrong.
>
> The idea of that message is to fix defects in checkpatch,
> not any other code.
>
> Maybe that could be reworded to
> "See the CHECKPATCH entry in the MAINTAINERS file of linux git"
> or some such.
I've dropped that change now in a re-sync to current checkpatch.pl.
Happy to pull in a re-wording of this part from a near-future resync
with the kernel :)
--
Tom
next prev parent reply other threads:[~2014-02-27 20:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 20:38 [PATCH] checkpatch.pl: Add warning for new __packed additions Tom Rini
2014-02-24 21:00 ` Joe Perches
2014-02-24 21:11 ` Tom Rini
2014-02-24 21:28 ` Joe Perches
2014-02-24 21:52 ` Tom Rini
2014-02-24 22:02 ` Joe Perches
2014-02-24 22:04 ` Tom Rini
2014-02-24 22:08 ` Joe Perches
2014-02-24 22:20 ` Tom Rini
2014-02-24 22:31 ` Joe Perches
2014-02-24 22:43 ` Tom Rini
2014-02-25 5:23 ` Joe Perches
2014-02-25 12:30 ` Tom Rini
2014-02-26 22:04 ` Joe Perches
2014-02-27 20:33 ` Tom Rini [this message]
2014-02-25 8:56 ` Heiko Carstens
2014-02-24 21:31 ` josh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=530FA0FF.9010202@ti.com \
--to=trini@ti.com \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox