From: Lars-Peter Clausen <lars@metafoo.de>
To: Xiubo Li <Li.Xiubo@freescale.com>
Cc: broonie@kernel.org, lgirdwood@gmail.com,
alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com,
abrestic@chromium.org, viresh.kumar@linaro.org, timur@tabi.org,
peter.ujfalusi@ti.com, mr.swami.reddy@ti.com,
voice.shen@atmel.com, mike.dyer@md-soft.co.uk,
bardliao@realtek.com, mahaijuns@gmail.com,
s.trumtrar@pengutronix.de, rf@opensource.wolfsonmicro.com,
LW@KARO-electronics.de, swarren@nvidia.com, shc_work@mail.ru,
vinod.koul@intel.com, b42378@freescale.com,
Paul.Handrigan@cirrus.com, vishwas.a.deshpande@ti.com,
Adam.Thomson.Opensource@diasemi.com, axel.lin@ingics.com,
ckeepax@opensource.wolfsonmicro.com, dgreid@chromium.org,
fabio.estevam@freescale.com, brian.austin@cirrus.com,
Andreas.Irestal@axis.com, linux-kernel@vger.kernel.org,
sachin.kamat@linaro.org, mpa@pengutronix.de,
shawn.guo@linaro.org, alban.bedel@avionic-design.de,
jic23@kernel.org
Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: io: Remove reduntant params of snd_soc_codec_set_cache_io()
Date: Fri, 28 Feb 2014 09:26:05 +0100 [thread overview]
Message-ID: <5310481D.3070106@metafoo.de> (raw)
In-Reply-To: <1393564009-15968-3-git-send-email-Li.Xiubo@freescale.com>
On 02/28/2014 06:06 AM, Xiubo Li wrote:
[...]
> @@ -118,7 +115,6 @@ int snd_soc_codec_set_cache_io(struct snd_soc_codec *codec,
> EXPORT_SYMBOL_GPL(snd_soc_codec_set_cache_io);
> #else
> int snd_soc_codec_set_cache_io(struct snd_soc_codec *codec,
> - int addr_bits, int data_bits,
> enum snd_soc_control_type control)
Since the only control type that is left is SND_SOC_REGMAP that can be
removed as well. And while you are at it I think we should make it possible
to specify the regmap struct as a parameter to snd_soc_codec_set_cache_io().
So basically the new signature of the function should be:
snd_soc_codec_set_cache_io(struct snd_soc_codec *codec, struct regmap *regmap)
if regmap is NULL the function should use dev_get_regmap(), otherwise use
the supplied regmap struct. This turns the two step initialization in the
form of
codec->control_data = priv->regmap;
snd_soc_codec_set_cache_io(codec, ...);
into
snd_soc_codec_set_cache_io(codec, priv->regmap);
which is much nicer in my opinion.
- Lars
prev parent reply other threads:[~2014-02-28 8:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 5:06 [PATCH 0/2] Simplify the CODEC ASoC probe code Xiubo Li
2014-02-28 5:06 ` [PATCH 1/2] ASoC: codec: Simplify " Xiubo Li
2014-02-28 5:06 ` [PATCH 2/2] ASoC: io: Remove reduntant params of snd_soc_codec_set_cache_io() Xiubo Li
2014-02-28 8:26 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5310481D.3070106@metafoo.de \
--to=lars@metafoo.de \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=Andreas.Irestal@axis.com \
--cc=LW@KARO-electronics.de \
--cc=Li.Xiubo@freescale.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=abrestic@chromium.org \
--cc=alban.bedel@avionic-design.de \
--cc=alsa-devel@alsa-project.org \
--cc=axel.lin@ingics.com \
--cc=b42378@freescale.com \
--cc=bardliao@realtek.com \
--cc=brian.austin@cirrus.com \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=dgreid@chromium.org \
--cc=fabio.estevam@freescale.com \
--cc=jic23@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mahaijuns@gmail.com \
--cc=mike.dyer@md-soft.co.uk \
--cc=mpa@pengutronix.de \
--cc=mr.swami.reddy@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=rf@opensource.wolfsonmicro.com \
--cc=s.trumtrar@pengutronix.de \
--cc=sachin.kamat@linaro.org \
--cc=shawn.guo@linaro.org \
--cc=shc_work@mail.ru \
--cc=swarren@nvidia.com \
--cc=timur@tabi.org \
--cc=vinod.koul@intel.com \
--cc=viresh.kumar@linaro.org \
--cc=vishwas.a.deshpande@ti.com \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox