Re: [PATCH v3] tty: Set correct tty name in 'active' sysfs attribute

[Hannes Reinecke <hare@suse.de>]

On 02/27/2014 12:30 PM, David Herrmann wrote:
> From: Hannes Reinecke <hare@suse.de>
> 
> The 'active' sysfs attribute should refer to the currently active tty
> devices the console is running on, not the currently active console. The
> console structure doesn't refer to any device in sysfs, only the tty the
> console is running on has. So we need to print out the tty names in
> 'active', not the console names.
> 
> There is one special-case, which is tty0. If the console is directed to
> it, we want 'tty0' to show up in the file, so user-space knows that the
> messages get forwarded to the active VT. The ->device() callback would
> resolve tty0, though. Hence, treat it special and don't call into the VT
> layer to resolve it (plymouth is known to depend on it).
> 
> Cc: Lennart Poettering <lennart@poettering.net>
> Cc: Kay Sievers <kay@vrfy.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Jiri Slaby <jslaby@suse.cz>
> Signed-off-by: Werner Fink <werner@suse.de>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: David Herrmann <dh.herrmann@gmail.com>
> ---
> v2: use cs[i]->index instead of ->index
>     refactor code to avoid >80 lines
>     split out sprintf("%c",...);
> 
> Tested on my x86-64 machine.

Thanks for this.
Patch looks good.

Acked-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)