linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sasha Levin <sasha.levin@oracle.com>
To: Sasha Levin <sasha.levin@oracle.com>,
	peterz@infradead.org, mingo@redhat.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] lockdep: increase static allocations
Date: Fri, 28 Feb 2014 14:32:25 -0500	[thread overview]
Message-ID: <5310E449.1050609@oracle.com> (raw)
In-Reply-To: <1389208906-24338-1-git-send-email-sasha.levin@oracle.com>

On 01/08/2014 02:21 PM, Sasha Levin wrote:
> Fuzzing a recent kernel with a large configuration hits the static
> allocation limits and disables lockdep.
>
> This patch doubles the limits.
>
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
>   kernel/locking/lockdep_internals.h | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/locking/lockdep_internals.h b/kernel/locking/lockdep_internals.h
> index 4f560cf..51c4b24 100644
> --- a/kernel/locking/lockdep_internals.h
> +++ b/kernel/locking/lockdep_internals.h
> @@ -54,9 +54,9 @@ enum {
>    * table (if it's not there yet), and we check it for lock order
>    * conflicts and deadlocks.
>    */
> -#define MAX_LOCKDEP_ENTRIES	16384UL
> +#define MAX_LOCKDEP_ENTRIES	32768UL
>
> -#define MAX_LOCKDEP_CHAINS_BITS	15
> +#define MAX_LOCKDEP_CHAINS_BITS	16
>   #define MAX_LOCKDEP_CHAINS	(1UL << MAX_LOCKDEP_CHAINS_BITS)
>
>   #define MAX_LOCKDEP_CHAIN_HLOCKS (MAX_LOCKDEP_CHAINS*5)
> @@ -65,7 +65,7 @@ enum {
>    * Stack-trace: tightly packed array of stack backtrace
>    * addresses. Protected by the hash_lock.
>    */
> -#define MAX_STACK_TRACE_ENTRIES	262144UL
> +#define MAX_STACK_TRACE_ENTRIES	524288UL
>
>   extern struct list_head all_lock_classes;
>   extern struct lock_chain lock_chains[];
>


Can someone pick the patch up please? PeterZ even (seemed to) acked it.


Thanks,
Sasha

  parent reply	other threads:[~2014-02-28 19:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-08 19:21 [PATCH] lockdep: increase static allocations Sasha Levin
2014-01-08 19:51 ` Andi Kleen
2014-01-08 20:10   ` Sasha Levin
2014-01-08 23:23     ` Andi Kleen
2014-01-09  8:56       ` Peter Zijlstra
2015-03-24 14:42         ` James Hogan
2014-02-28 19:32 ` Sasha Levin [this message]
2014-03-01  4:33   ` Mike Galbraith
2014-04-07 21:51   ` Sasha Levin
2014-04-08  9:10     ` Peter Zijlstra
2014-04-18 13:13 ` [tip:locking/core] lockdep: Increase " tip-bot for Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5310E449.1050609@oracle.com \
    --to=sasha.levin@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).