From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752767AbaCBPU4 (ORCPT ); Sun, 2 Mar 2014 10:20:56 -0500 Received: from mail-ea0-f178.google.com ([209.85.215.178]:53055 "EHLO mail-ea0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750948AbaCBPUz (ORCPT ); Sun, 2 Mar 2014 10:20:55 -0500 Message-ID: <53134C4D.2090406@linux.com> Date: Sun, 02 Mar 2014 16:20:45 +0100 From: Levente Kurusa Reply-To: Levente Kurusa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Yogesh Chaudhari , LKML CC: joe@perches.com, apw@canonical.com Subject: Re: [PATCH 1/1] scripts/checkpatch.pl: to give more detailed warning message in case printk is used in any patch References: In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 03/02/2014 04:01 PM, Yogesh Chaudhari wrote: > Based on the discussion here: > https://lkml.org/lkml/2014/3/2/17 > > I would like to propose this patch to improve the warning message in > checkpatch.pl. Comments/Suggestions on possible improvements are > welcome. > > > ========================================================= > > This patch modifies scripts/checkpatch.pl to give more detailed > warning message in case printk is used in any patch. > > Signed-off-by: Yogesh Chaudhari > --- > scripts/checkpatch.pl | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl > index 464dcef..526f33aa 100755 > --- a/scripts/checkpatch.pl > +++ b/scripts/checkpatch.pl > @@ -2799,7 +2799,10 @@ sub process { > my $level2 = $level; > $level2 = "dbg" if ($level eq "debug"); > WARN("PREFER_PR_LEVEL", > - "Prefer netdev_$level2(netdev, ... then > dev_$level2(dev, ... then pr_$level(... to printk(KERN_$orig ...\n" . > $herecurr); Whoops, that's a word-wrap! Try using git-format-patch+git-send-email to send the patch. > + "Order of preference for printing debug messages: > + 1. [subsystem]_$level2([subsystem]dev, ... eg > netdev_$level2(netdev, ... for netdevice object > + 2. dev_$level2(dev, ... for drivers with struct device > + 3. pr_$level(... to printk(KERN_$orig ...\n" . $herecurr); > } > > if ($line =~ /\bpr_warning\s*\(/) { > IMHO, this message is too big. The one we already have is nice and clean. I would simply do: s/netdev/[subsystem]/ or something among the lines. -- Regards, Levente Kurusa