From: Li Zefan <lizefan@huawei.com>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cpuset: Add missing rcu read locks
Date: Mon, 3 Mar 2014 16:32:46 +0800 [thread overview]
Message-ID: <53143E2E.6010302@huawei.com> (raw)
In-Reply-To: <1393510855-8771-1-git-send-email-sasha.levin@oracle.com>
On 2014/2/27 22:20, Sasha Levin wrote:
> We call task_cs() which ends up going into cgroup code without having rcu
> read lock. Fix it by grabbing the lock before retrival of task_cs() and usage
> of the result.
>
Thanks for the patch.
Fengguang already reported it, and I've made a patch for it, but I was fixing
two bugs for 3.14 and then waiting for them to be applied.
There're other places that rcu_read_lock() should be used, and we need to
remove task_lock().
prev parent reply other threads:[~2014-03-03 8:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-27 14:20 [PATCH] cpuset: Add missing rcu read locks Sasha Levin
2014-03-03 8:32 ` Li Zefan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53143E2E.6010302@huawei.com \
--to=lizefan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sasha.levin@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox