From: "H. Peter Anvin" <hpa@zytor.com>
To: Petr Mladek <pmladek@suse.cz>, Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Jiri Kosina <jkosina@suse.cz>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH 1/3] ftrace/x86: One more missing sync after fixup of function modification failure
Date: Mon, 03 Mar 2014 14:13:54 -0800 [thread overview]
Message-ID: <5314FEA2.2030408@zytor.com> (raw)
In-Reply-To: <1393258342-29978-2-git-send-email-pmladek@suse.cz>
On 02/24/2014 08:12 AM, Petr Mladek wrote:
> If a failure occurs while modifying ftrace function, it bails out and will
> remove the tracepoints to be back to what the code originally was.
>
> There is missing the final sync run across the CPUs after the fix up is done
> and before the ftrace int3 handler flag is reset.
>
> Signed-off-by: Petr Mladek <pmladek@suse.cz>
> ---
> arch/x86/kernel/ftrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: H. Peter Anvin <hpa@linux.intel.com>
next prev parent reply other threads:[~2014-03-03 22:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 16:12 [PATCH v2 0/3] ftrace/x86: Recovery code fixes and improvements Petr Mladek
2014-02-24 16:12 ` [PATCH 1/3] ftrace/x86: One more missing sync after fixup of function modification failure Petr Mladek
2014-03-03 22:13 ` H. Peter Anvin [this message]
2014-02-24 16:12 ` [PATCH 2/3] ftrace: Warn on error when modifying ftrace function Petr Mladek
2014-02-24 16:12 ` [PATCH 3/3] ftrace/x86: BUG when ftrace recovery fails Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5314FEA2.2030408@zytor.com \
--to=hpa@zytor.com \
--cc=fweisbec@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pmladek@suse.cz \
--cc=rostedt@goodmis.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox