From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Tudor Ambarus" <tudor.ambarus@linaro.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Alim Akhtar" <alim.akhtar@samsung.com>,
"Peter Griffin" <peter.griffin@linaro.org>,
"André Draszik" <andre.draszik@linaro.org>,
"Srinivas Kandagatla" <srini@kernel.org>
Cc: semen.protsenko@linaro.org, willmcvicker@google.com,
kernel-team@android.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 0/6] soc: samsung: exynos-chipid: add gs101 support
Date: Sun, 21 Dec 2025 14:50:38 +0100 [thread overview]
Message-ID: <5314fc2e-e21f-4a2b-8970-c856049edb72@kernel.org> (raw)
In-Reply-To: <20251120-gs101-chipid-v3-0-1aeaa8b7fe35@linaro.org>
On 20/11/2025 12:29, Tudor Ambarus wrote:
> Dependency
> ==========
> Typical dependency of the DT patch depending on the bindings patch,
> thus the bindings patch could go via the Samsung SoC tree with
> Srinivas's ack.
>
> Description
> ===========
> GS101 is different (but also e850 and autov9 I assume) from the SoCs
> that are currently handled by the exynos-chipid driver because the
> chip ID info is part of the OTP registers. GS101 OTP has a clock, an
> interrupt line, a register space (that contains product and chip ID,
> TMU data, ASV, etc) and a 32Kbit memory space that can be
> read/program/locked with specific commands. On GS101 the "ChipID block"
> is just an abstraction, it's not a physical device. When the power-on
> sequence progresses, the OTP chipid values are loaded to the OTP
> registers.
>
> Add the GS101 chip ID support. The support is intentionally added in the
> exynos-chipid driver, and not in a dedicated Exynos OTP driver, because
> we estimate that there will not be any OTP consumers in the kernel other
> than the chip ID/SoC interface. The downstream GS101 drivers confirm
> this supposition.
>
Patches look fine to me, I took already two, but the rest please send
new version after implementing Andre's feedback (thanks for review!).
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-12-21 13:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 11:29 [PATCH v3 0/6] soc: samsung: exynos-chipid: add gs101 support Tudor Ambarus
2025-11-20 11:29 ` [PATCH v3 1/6] soc: samsung: exynos-chipid: use devm action to unregister soc device Tudor Ambarus
2025-12-19 14:53 ` André Draszik
2025-11-20 11:29 ` [PATCH v3 2/6] soc: samsung: exynos-chipid: use dev_err_probe where appropiate Tudor Ambarus
2025-12-19 14:57 ` André Draszik
2025-11-20 11:29 ` [PATCH v3 3/6] soc: samsung: exynos-chipid: rename method Tudor Ambarus
2025-11-20 11:29 ` [PATCH v3 4/6] soc: samsung: exynos-chipid: downgrade dev_info to dev_dbg for soc info Tudor Ambarus
2025-12-19 14:58 ` André Draszik
2025-11-20 11:29 ` [PATCH v3 5/6] soc: samsung: exynos-chipid: add google,gs101-otp support Tudor Ambarus
2025-12-19 15:10 ` André Draszik
2025-12-22 14:12 ` Tudor Ambarus
2025-12-22 14:39 ` André Draszik
2025-11-20 11:29 ` [PATCH v3 6/6] arm64: dts: exynos: gs101: add OTP node Tudor Ambarus
2025-12-21 13:50 ` Krzysztof Kozlowski [this message]
2025-12-21 13:52 ` (subset) [PATCH v3 0/6] soc: samsung: exynos-chipid: add gs101 support Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5314fc2e-e21f-4a2b-8970-c856049edb72@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=andre.draszik@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel-team@android.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=semen.protsenko@linaro.org \
--cc=srini@kernel.org \
--cc=tudor.ambarus@linaro.org \
--cc=willmcvicker@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox