From: Chris Metcalf <cmetcalf@tilera.com>
To: Bjorn Helgaas <bhelgaas@google.com>, <linux-pci@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 6/7] tile PCI RC: Use default pcibios_enable_device()
Date: Tue, 4 Mar 2014 12:20:17 -0500 [thread overview]
Message-ID: <53160B51.90309@tilera.com> (raw)
In-Reply-To: <20140226234208.18970.41395.stgit@bhelgaas-glaptop.roam.corp.google.com>
On 2/26/2014 6:42 PM, Bjorn Helgaas wrote:
> We don't need anything arch-specific in pcibios_enable_device(), so drop
> the arch implementation and use the default generic one.
>
> Note: pci_enable_resources() checks that r->parent is non-NULL, which
> basically checks that pci_claim_resource() or request_resource() has been
> called for each BAR. I don't see where that happens for tile, but this
> patch doesn't change that behavior, so if it worked before, it should still
> work.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> CC: Chris Metcalf <cmetcalf@tilera.com>
> ---
> arch/tile/kernel/pci_gx.c | 12 ------------
> 1 file changed, 12 deletions(-)
>
Acked-by: Chris Metcalf <cmetcalf@tilera.com>
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
next prev parent reply other threads:[~2014-03-04 17:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-26 23:41 [PATCH 0/7] PCI: Use default pcibios_enable_device() Bjorn Helgaas
2014-02-26 23:41 ` [PATCH 1/7] PCI: Add "weak" generic pcibios_enable_device() implementation Bjorn Helgaas
2014-02-26 23:41 ` [PATCH 2/7] alpha/PCI: Use default pcibios_enable_device() Bjorn Helgaas
2014-02-26 23:41 ` [PATCH 3/7] microblaze/PCI: " Bjorn Helgaas
2014-02-26 23:41 ` [PATCH 4/7] sh/PCI: " Bjorn Helgaas
2014-02-26 23:42 ` [PATCH 5/7] sparc/PCI: Use default pcibios_enable_device() (Leon only) Bjorn Helgaas
2014-02-26 23:42 ` [PATCH 6/7] tile PCI RC: Use default pcibios_enable_device() Bjorn Helgaas
2014-03-04 17:20 ` Chris Metcalf [this message]
2014-02-26 23:42 ` [PATCH 7/7] s390/PCI: Use generic pci_enable_resources() Bjorn Helgaas
2014-03-03 13:35 ` Sebastian Ott
2014-03-03 16:13 ` Bjorn Helgaas
2014-03-04 20:53 ` [PATCH 0/7] PCI: Use default pcibios_enable_device() Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53160B51.90309@tilera.com \
--to=cmetcalf@tilera.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox