From: Li Zefan <lizefan@huawei.com>
To: Tejun Heo <tj@kernel.org>
Cc: Sasha Levin <sasha.levin@oracle.com>,
<containers@lists.linux-foundation.org>,
<cgroups@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cgroup: missing rcu read lock around task_css_set
Date: Wed, 5 Mar 2014 08:57:06 +0800 [thread overview]
Message-ID: <53167662.5000801@huawei.com> (raw)
In-Reply-To: <20140304194741.GA2204@htj.dyndns.org>
On 2014/3/5 3:47, Tejun Heo wrote:
> On Tue, Mar 04, 2014 at 12:20:45PM -0500, Sasha Levin wrote:
>>> Hrm... there is a PF_EXITING check there already:
>>>
>>> #define task_css_set_check(task, __c) \
>>> rcu_dereference_check((task)->cgroups, \
>>> lockdep_is_held(&cgroup_mutex) || \
>>> lockdep_is_held(&css_set_rwsem) || \
>>> ((task)->flags & PF_EXITING) || (__c))
>>>
>>> I see it's not happening on Linus's master so I'll run a bisection to figure out what broke it.
>>
>> Hi Tejun,
>>
>> It bisects down to your patch: "cgroup: drop task_lock() protection
>> around task->cgroups". I'll look into it later unless it's obvious
>> to you.
>
> Hmmm... maybe I'm confused and PF_EXITING is not set there and
> task_lock was what held off the lockdep warning. Confused....
>
Because this cgroup_exit() is called in a failure path in copy_process().
next prev parent reply other threads:[~2014-03-05 0:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 3:00 [PATCH] cgroup: missing rcu read lock around task_css_set Sasha Levin
2014-03-03 22:33 ` Tejun Heo
2014-03-03 22:43 ` Sasha Levin
2014-03-03 22:45 ` Tejun Heo
2014-03-03 22:48 ` Sasha Levin
2014-03-03 23:00 ` Sasha Levin
2014-03-04 17:20 ` Sasha Levin
2014-03-04 19:47 ` Tejun Heo
2014-03-05 0:57 ` Li Zefan [this message]
2014-03-27 15:35 ` Sasha Levin
2014-03-28 2:48 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53167662.5000801@huawei.com \
--to=lizefan@huawei.com \
--cc=cgroups@vger.kernel.org \
--cc=containers@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sasha.levin@oracle.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox