* [PATCH] mfd: pm8921: fixup probe() error path when irq invalid
@ 2014-03-05 19:34 Josh Cartwright
2014-03-05 19:46 ` Stephen Boyd
2014-03-06 9:20 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Josh Cartwright @ 2014-03-05 19:34 UTC (permalink / raw)
To: David Brown, Daniel Walker, Bryan Huntsman, Samuel Ortiz,
Lee Jones
Cc: Stephen Boyd, linux-arm-msm, linux-kernel
platform_get_irq() returns a negative error code when an IRQ is invalid
or unspecified. Make 'irq' signed to properly handle this.
Cc: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Josh Cartwright <joshc@codeaurora.org>
---
drivers/mfd/pm8921-core.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mfd/pm8921-core.c b/drivers/mfd/pm8921-core.c
index 3aab6ac..d48452d 100644
--- a/drivers/mfd/pm8921-core.c
+++ b/drivers/mfd/pm8921-core.c
@@ -403,9 +403,8 @@ static int pm8921_probe(struct platform_device *pdev)
{
struct pm8921 *pmic;
struct regmap *regmap;
- int rc;
+ int irq, rc;
unsigned int val;
- unsigned int irq;
u32 rev;
struct pm_irq_chip *chip;
unsigned int nirqs = PM8921_NR_IRQS;
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: pm8921: fixup probe() error path when irq invalid
2014-03-05 19:34 [PATCH] mfd: pm8921: fixup probe() error path when irq invalid Josh Cartwright
@ 2014-03-05 19:46 ` Stephen Boyd
2014-03-06 9:20 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Stephen Boyd @ 2014-03-05 19:46 UTC (permalink / raw)
To: Josh Cartwright
Cc: David Brown, Daniel Walker, Bryan Huntsman, Samuel Ortiz,
Lee Jones, linux-arm-msm, linux-kernel
On 03/05/14 11:34, Josh Cartwright wrote:
> platform_get_irq() returns a negative error code when an IRQ is invalid
> or unspecified. Make 'irq' signed to properly handle this.
>
Reviewed-by: Stephen Boyd <sboyd@codeaurora.org>
Thanks
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: pm8921: fixup probe() error path when irq invalid
2014-03-05 19:34 [PATCH] mfd: pm8921: fixup probe() error path when irq invalid Josh Cartwright
2014-03-05 19:46 ` Stephen Boyd
@ 2014-03-06 9:20 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2014-03-06 9:20 UTC (permalink / raw)
To: Josh Cartwright
Cc: David Brown, Daniel Walker, Bryan Huntsman, Samuel Ortiz,
Stephen Boyd, linux-arm-msm, linux-kernel
> platform_get_irq() returns a negative error code when an IRQ is invalid
> or unspecified. Make 'irq' signed to properly handle this.
>
> Cc: Stephen Boyd <sboyd@codeaurora.org>
> Signed-off-by: Josh Cartwright <joshc@codeaurora.org>
> ---
> drivers/mfd/pm8921-core.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-06 9:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-05 19:34 [PATCH] mfd: pm8921: fixup probe() error path when irq invalid Josh Cartwright
2014-03-05 19:46 ` Stephen Boyd
2014-03-06 9:20 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox