From: Jens Axboe <axboe@kernel.dk>
To: Roman Pen <r.peniaev@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] blktrace: fix accounting of partially completed requests
Date: Wed, 05 Mar 2014 16:10:09 -0700 [thread overview]
Message-ID: <5317AED1.4050104@kernel.dk> (raw)
In-Reply-To: <1393942390-21293-1-git-send-email-r.peniaev@gmail.com>
On 03/04/2014 07:13 AM, Roman Pen wrote:
> trace_block_rq_complete does not take into account that request can
> be partially completed, so we can get the following incorrect output
> of blkparser:
>
> C R 232 + 240 [0]
> C R 240 + 232 [0]
> C R 248 + 224 [0]
> C R 256 + 216 [0]
>
> but should be:
>
> C R 232 + 8 [0]
> C R 240 + 8 [0]
> C R 248 + 8 [0]
> C R 256 + 8 [0]
>
> Also, the whole output summary statistics of completed requests and
> final throughput will be incorrect.
>
> This patch takes into account real completion size of the request and
> fixes wrong completion accounting.
Thanks Roman, this looks good. I'll apply it for 3.15, but with an added
stable tag as well.
--
Jens Axboe
prev parent reply other threads:[~2014-03-05 23:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 14:13 [PATCH 1/1] blktrace: fix accounting of partially completed requests Roman Pen
2014-03-05 23:10 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5317AED1.4050104@kernel.dk \
--to=axboe@kernel.dk \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=r.peniaev@gmail.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox