From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751650AbaCFFdx (ORCPT ); Thu, 6 Mar 2014 00:33:53 -0500 Received: from mga03.intel.com ([143.182.124.21]:3232 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750828AbaCFFdv (ORCPT ); Thu, 6 Mar 2014 00:33:51 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.97,598,1389772800"; d="scan'208";a="486962591" Message-ID: <531808BD.4070000@linux.intel.com> Date: Thu, 06 Mar 2014 13:33:49 +0800 From: "Li, Aubrey" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: "H. Peter Anvin" , Matthew Garrett , mingo@redhat.com, tglx@linutronix.de, linux-kernel@vger.kernel.org, "alan@linux.intel.com" Subject: Re: [PATCH] x86: new Intel Atom SoC power management controller driver References: <5317EC0C.4010807@linux.intel.com> <5317F044.8080407@linux.intel.com> <531805D4.6040806@linux.intel.com> <5318076C.7080605@linux.intel.com> In-Reply-To: <5318076C.7080605@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014/3/6 13:28, H. Peter Anvin wrote: > On 03/05/2014 09:21 PM, Li, Aubrey wrote: >>> >>> What is the reason for putting this in debugfs? >> >> S0ix support on Atom SoC needs all of the devices under south complex to >> be quiesced, as well as the devices under north complex. This interface >> shows all of the devices states under platform control unit. If the >> system is not able to enter S0ix, we have a way to diagnose. Or if the >> system entered S0ix, we have counters to show S0ix entered and its >> residency. >> > > I guess the real question is: are you sure this is only for debugging, > or is this going to be an interface that applications or daemons will > actually use (in which case it should live in sysfs). These interfaces are uncommitted and don't have consumers now, I'd like to keep them unstable in debugfs. We can change it if we received a requirement to use them later. Thanks, -Aubrey > > -hpa > > > >