From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752829AbaCFKJq (ORCPT ); Thu, 6 Mar 2014 05:09:46 -0500 Received: from mail-ea0-f174.google.com ([209.85.215.174]:59405 "EHLO mail-ea0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900AbaCFKJn (ORCPT ); Thu, 6 Mar 2014 05:09:43 -0500 Message-ID: <53184962.3080100@redhat.com> Date: Thu, 06 Mar 2014 11:09:38 +0100 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Fam Zheng , linux-kernel@vger.kernel.org CC: linux-scsi@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] virtio-scsi: Change sense buffer size to 252 References: <1394095660-15075-1-git-send-email-famz@redhat.com> In-Reply-To: <1394095660-15075-1-git-send-email-famz@redhat.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 06/03/2014 09:47, Fam Zheng ha scritto: > According to SPC-4, section 4.5.2.1, 252 is the limit of sense data. So > increase the value. > > Signed-off-by: Fam Zheng > --- > include/linux/virtio_scsi.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/virtio_scsi.h b/include/linux/virtio_scsi.h > index 4195b97..a437f7f 100644 > --- a/include/linux/virtio_scsi.h > +++ b/include/linux/virtio_scsi.h > @@ -28,7 +28,7 @@ > #define _LINUX_VIRTIO_SCSI_H > > #define VIRTIO_SCSI_CDB_SIZE 32 > -#define VIRTIO_SCSI_SENSE_SIZE 96 > +#define VIRTIO_SCSI_SENSE_SIZE 252 > > /* SCSI command request, followed by data-out */ > struct virtio_scsi_cmd_req { > Hi Fam, how did you test this? Paolo