From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751695AbaCFLz4 (ORCPT ); Thu, 6 Mar 2014 06:55:56 -0500 Received: from mx1.redhat.com ([209.132.183.28]:40655 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750885AbaCFLzx (ORCPT ); Thu, 6 Mar 2014 06:55:53 -0500 Message-ID: <53186241.5060106@redhat.com> Date: Thu, 06 Mar 2014 12:55:45 +0100 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Hannes Reinecke , Fam Zheng , linux-kernel@vger.kernel.org CC: linux-scsi@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] virtio-scsi: Change sense buffer size to 252 References: <1394095660-15075-1-git-send-email-famz@redhat.com> <53184962.3080100@redhat.com> <53185A79.9010206@suse.de> In-Reply-To: <53185A79.9010206@suse.de> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 06/03/2014 12:22, Hannes Reinecke ha scritto: > On 03/06/2014 11:09 AM, Paolo Bonzini wrote: >> Il 06/03/2014 09:47, Fam Zheng ha scritto: >>> According to SPC-4, section 4.5.2.1, 252 is the limit of sense >>> data. So >>> increase the value. >>> >>> Signed-off-by: Fam Zheng >>> --- >>> include/linux/virtio_scsi.h | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/include/linux/virtio_scsi.h >>> b/include/linux/virtio_scsi.h >>> index 4195b97..a437f7f 100644 >>> --- a/include/linux/virtio_scsi.h >>> +++ b/include/linux/virtio_scsi.h >>> @@ -28,7 +28,7 @@ >>> #define _LINUX_VIRTIO_SCSI_H >>> >>> #define VIRTIO_SCSI_CDB_SIZE 32 >>> -#define VIRTIO_SCSI_SENSE_SIZE 96 >>> +#define VIRTIO_SCSI_SENSE_SIZE 252 >>> >>> /* SCSI command request, followed by data-out */ >>> struct virtio_scsi_cmd_req { >>> >> >> Hi Fam, how did you test this? > > Is there a specific reason _not_ to use the linux default? > The SCSI stack typically limits the sense code to > SCSI_SENSE_BUFFERSIZE, so using other values have a > limited sense. > Literally :-) Indeed I don't think this patch makes a difference. Though I asked not from the SCSI stack perspective, but because right now both virtio-scsi targets (QEMU and vhost-scsi) are also truncating at 96. Paolo