From: Chris Metcalf <cmetcalf@tilera.com>
To: Henrik Austad <henrik@austad.us>
Cc: LKML <linux-kernel@vger.kernel.org>,
John Stultz <johnstul@us.ibm.com>,
Mike Galbraith <bitbucket@online.de>,
Salman Qazi <sqazi@google.com>
Subject: Re: [PATCH] tile: avoid overflow in ns2cycles
Date: Thu, 6 Mar 2014 11:53:19 -0500 [thread overview]
Message-ID: <5318A7FF.8010502@tilera.com> (raw)
In-Reply-To: <1393921253-23396-1-git-send-email-henrik@austad.us>
On 3/4/2014 3:20 AM, Henrik Austad wrote:
> In commit 4cecf6d401a ("sched, x86: Avoid unnecessary overflow in
> sched_clock") and in recent patch "clocksource: avoid unnecessary
> overflow in cyclecounter_cyc2ns()" https://lkml.org/lkml/2014/3/4/17,
> the mult-shift approach is replaced by 2 steps to avoid storing a large,
> intermediate value that could overflow.
>
> arch/tile/kernel/time.c has a similar pattern in cycles2ns, and this
> copies the same pattern in this function
>
> CC: John Stultz <johnstul@us.ibm.com>
> CC: Mike Galbraith <bitbucket@online.de>
> CC: Salman Qazi <sqazi@google.com>
> Signed-off-by: Henrik Austad <henrik@austad.us>
> ---
> arch/tile/kernel/time.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
Thanks; taken into the tile tree (with some minor whitespace formatting tweaks).
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
prev parent reply other threads:[~2014-03-06 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 8:20 [PATCH] tile: avoid overflow in ns2cycles Henrik Austad
2014-03-06 16:53 ` Chris Metcalf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5318A7FF.8010502@tilera.com \
--to=cmetcalf@tilera.com \
--cc=bitbucket@online.de \
--cc=henrik@austad.us \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sqazi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox