From: Markos Chandras <Markos.Chandras@imgtec.com>
To: David Miller <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>, <dborkman@redhat.com>
Subject: Re: [PATCH] tools/net/Makefile: Define PACKAGE to fix bfd build problems
Date: Fri, 7 Mar 2014 09:18:28 +0000 [thread overview]
Message-ID: <53198EE4.8030103@imgtec.com> (raw)
In-Reply-To: <20140306.125412.1583267049751920093.davem@davemloft.net>
On 03/06/2014 05:54 PM, David Miller wrote:
> From: Markos Chandras <markos.chandras@imgtec.com>
> Date: Thu, 6 Mar 2014 09:15:54 +0000
>
>> Fixes the following build problem with binutils-2.24
>>
>> gcc -Wall -O2 -c -o bpf_jit_disasm.o bpf_jit_disasm.c
>> In file included from bpf_jit_disasm.c:25:0:
>> /usr/include/bfd.h:35:2: error: #error config.h must be included
>> before this header
>> #error config.h must be included before this header
>>
>> This is similar to commit 3ce711a6abc27abce1554e1d671a8762b7187690
>> "perf tools: bfd.h/libbfd detection fails with recent binutils"
>>
>> See: https://sourceware.org/bugzilla/show_bug.cgi?id=14243
>>
>> CC: David S. Miller <davem@davemloft.net>
>> CC: Daniel Borkmann <dborkman@redhat.com>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>
> I think your subject needs to be adjusted, this patch doesn't fix a "bfd"
> build problem.
>
Hi David,
Thanks for the comment. Well it's problem caused by the bfd header.
However, I suppose you can remove the 'bfd' word from the subject as I
understand it's confusing. Would you be able to fix this before you
apply this patch or should I send a new patch?
--
markos
next prev parent reply other threads:[~2014-03-07 9:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 9:15 [PATCH] tools/net/Makefile: Define PACKAGE to fix bfd build problems Markos Chandras
2014-03-06 9:40 ` Daniel Borkmann
2014-03-06 17:54 ` David Miller
2014-03-07 9:18 ` Markos Chandras [this message]
2014-03-07 18:09 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53198EE4.8030103@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox