[PATCH] tools/net/Makefile: Define PACKAGE to fix bfd build problems

[PATCH] tools/net/Makefile: Define PACKAGE to fix bfd build problems

[Markos Chandras]

Fixes the following build problem with binutils-2.24

gcc -Wall -O2   -c -o bpf_jit_disasm.o bpf_jit_disasm.c
In file included from bpf_jit_disasm.c:25:0:
/usr/include/bfd.h:35:2: error: #error config.h must be included
before this header
 #error config.h must be included before this header

This is similar to commit 3ce711a6abc27abce1554e1d671a8762b7187690
"perf tools: bfd.h/libbfd detection fails with recent binutils"

See: https://sourceware.org/bugzilla/show_bug.cgi?id=14243

CC: David S. Miller <davem@davemloft.net>
CC: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
---
 tools/net/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/net/Makefile b/tools/net/Makefile
index 004cd74..ee577ea 100644
--- a/tools/net/Makefile
+++ b/tools/net/Makefile
@@ -12,7 +12,7 @@ YACC = bison
 
 all : bpf_jit_disasm bpf_dbg bpf_asm
 
-bpf_jit_disasm : CFLAGS = -Wall -O2
+bpf_jit_disasm : CFLAGS = -Wall -O2 -DPACKAGE='bpf_jit_disasm'
 bpf_jit_disasm : LDLIBS = -lopcodes -lbfd -ldl
 bpf_jit_disasm : bpf_jit_disasm.o
 
-- 
1.9.0

Re: [PATCH] tools/net/Makefile: Define PACKAGE to fix bfd build problems

[Daniel Borkmann]

On 03/06/2014 10:15 AM, Markos Chandras wrote:
> Fixes the following build problem with binutils-2.24
>
> gcc -Wall -O2   -c -o bpf_jit_disasm.o bpf_jit_disasm.c
> In file included from bpf_jit_disasm.c:25:0:
> /usr/include/bfd.h:35:2: error: #error config.h must be included
> before this header
>   #error config.h must be included before this header
>
> This is similar to commit 3ce711a6abc27abce1554e1d671a8762b7187690
> "perf tools: bfd.h/libbfd detection fails with recent binutils"
>
> See: https://sourceware.org/bugzilla/show_bug.cgi?id=14243
>
> CC: David S. Miller <davem@davemloft.net>
> CC: Daniel Borkmann <dborkman@redhat.com>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>

Acked-by: Daniel Borkmann <dborkman@redhat.com>

Re: [PATCH] tools/net/Makefile: Define PACKAGE to fix bfd build problems

[David Miller]

From: Markos Chandras <markos.chandras@imgtec.com>
Date: Thu, 6 Mar 2014 09:15:54 +0000

> Fixes the following build problem with binutils-2.24
> 
> gcc -Wall -O2   -c -o bpf_jit_disasm.o bpf_jit_disasm.c
> In file included from bpf_jit_disasm.c:25:0:
> /usr/include/bfd.h:35:2: error: #error config.h must be included
> before this header
>  #error config.h must be included before this header
> 
> This is similar to commit 3ce711a6abc27abce1554e1d671a8762b7187690
> "perf tools: bfd.h/libbfd detection fails with recent binutils"
> 
> See: https://sourceware.org/bugzilla/show_bug.cgi?id=14243
> 
> CC: David S. Miller <davem@davemloft.net>
> CC: Daniel Borkmann <dborkman@redhat.com>
> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>

I think your subject needs to be adjusted, this patch doesn't fix a "bfd"
build problem.

Re: [PATCH] tools/net/Makefile: Define PACKAGE to fix bfd build problems

[Markos Chandras]

On 03/06/2014 05:54 PM, David Miller wrote:
> From: Markos Chandras <markos.chandras@imgtec.com>
> Date: Thu, 6 Mar 2014 09:15:54 +0000
>
>> Fixes the following build problem with binutils-2.24
>>
>> gcc -Wall -O2   -c -o bpf_jit_disasm.o bpf_jit_disasm.c
>> In file included from bpf_jit_disasm.c:25:0:
>> /usr/include/bfd.h:35:2: error: #error config.h must be included
>> before this header
>>   #error config.h must be included before this header
>>
>> This is similar to commit 3ce711a6abc27abce1554e1d671a8762b7187690
>> "perf tools: bfd.h/libbfd detection fails with recent binutils"
>>
>> See: https://sourceware.org/bugzilla/show_bug.cgi?id=14243
>>
>> CC: David S. Miller <davem@davemloft.net>
>> CC: Daniel Borkmann <dborkman@redhat.com>
>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>
> I think your subject needs to be adjusted, this patch doesn't fix a "bfd"
> build problem.
>
Hi David,

Thanks for the comment. Well it's problem caused by the bfd header. 
However, I suppose you can remove the 'bfd' word from the subject as I 
understand it's confusing. Would you be able to fix this before you 
apply this patch or should I send a new patch?

-- 
markos

Re: [PATCH] tools/net/Makefile: Define PACKAGE to fix bfd build problems

[David Miller]

From: Markos Chandras <Markos.Chandras@imgtec.com>
Date: Fri, 7 Mar 2014 09:18:28 +0000

> On 03/06/2014 05:54 PM, David Miller wrote:
>> From: Markos Chandras <markos.chandras@imgtec.com>
>> Date: Thu, 6 Mar 2014 09:15:54 +0000
>>
>>> Fixes the following build problem with binutils-2.24
>>>
>>> gcc -Wall -O2   -c -o bpf_jit_disasm.o bpf_jit_disasm.c
>>> In file included from bpf_jit_disasm.c:25:0:
>>> /usr/include/bfd.h:35:2: error: #error config.h must be included
>>> before this header
>>>   #error config.h must be included before this header
>>>
>>> This is similar to commit 3ce711a6abc27abce1554e1d671a8762b7187690
>>> "perf tools: bfd.h/libbfd detection fails with recent binutils"
>>>
>>> See: https://sourceware.org/bugzilla/show_bug.cgi?id=14243
>>>
>>> CC: David S. Miller <davem@davemloft.net>
>>> CC: Daniel Borkmann <dborkman@redhat.com>
>>> Signed-off-by: Markos Chandras <markos.chandras@imgtec.com>
>>
>> I think your subject needs to be adjusted, this patch doesn't fix a
>> "bfd"
>> build problem.
>>
> Hi David,
> 
> Thanks for the comment. Well it's problem caused by the bfd
> header. However, I suppose you can remove the 'bfd' word from the
> subject as I understand it's confusing. Would you be able to fix this
> before you apply this patch or should I send a new patch?

Please send a new patch, thanks.