* [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.
2014-02-04 11:10 ` [PATCH] " Denis Turischev
@ 2014-02-18 7:42 ` Denis Turischev
2014-02-18 18:54 ` Sarah Sharp
0 siblings, 1 reply; 8+ messages in thread
From: Denis Turischev @ 2014-02-18 7:42 UTC (permalink / raw)
To: Sarah Sharp; +Cc: linux-kernel, linux-usb, Greg Kroah-Hartman
The same issue like with Panther Point chipsets. If the USB ports are
switched to xHCI on shutdown, the xHCI host will send a spurious interrupt,
which will wake the system. Some BIOS have work around for this, but not all.
One example is Compulab's mini-desktop, the Intense-PC2.
The bug can be avoided if the USB ports are switched back to EHCI on
shutdown.
Signed-off-by: Denis Turischev <denis@compulab.co.il>
---
drivers/usb/host/xhci-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 3c898c1..9233d12 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -134,6 +134,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
*/
if (pdev->subsystem_vendor == PCI_VENDOR_ID_HP)
xhci->quirks |= XHCI_SPURIOUS_WAKEUP;
+
+ xhci->quirks |= XHCI_SPURIOUS_REBOOT;
}
if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
pdev->device == PCI_DEVICE_ID_ASROCK_P67) {
-- 1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.
2014-02-18 7:42 ` [RESEND] " Denis Turischev
@ 2014-02-18 18:54 ` Sarah Sharp
0 siblings, 0 replies; 8+ messages in thread
From: Sarah Sharp @ 2014-02-18 18:54 UTC (permalink / raw)
To: Denis Turischev; +Cc: linux-kernel, linux-usb, Greg Kroah-Hartman
Sorry for the delay in reviewing this. It helps me if you don't make the
patch in-reply-to a months old thread. :) I'll take a look at this
shortly.
Sarah Sharp
On Tue, Feb 18, 2014 at 09:42:39AM +0200, Denis Turischev wrote:
> The same issue like with Panther Point chipsets. If the USB ports are
> switched to xHCI on shutdown, the xHCI host will send a spurious interrupt,
> which will wake the system. Some BIOS have work around for this, but not all.
> One example is Compulab's mini-desktop, the Intense-PC2.
>
> The bug can be avoided if the USB ports are switched back to EHCI on
> shutdown.
>
> Signed-off-by: Denis Turischev <denis@compulab.co.il>
> ---
> drivers/usb/host/xhci-pci.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index 3c898c1..9233d12 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -134,6 +134,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
> */
> if (pdev->subsystem_vendor == PCI_VENDOR_ID_HP)
> xhci->quirks |= XHCI_SPURIOUS_WAKEUP;
> +
> + xhci->quirks |= XHCI_SPURIOUS_REBOOT;
> }
> if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
> pdev->device == PCI_DEVICE_ID_ASROCK_P67) {
> -- 1.8.1.2
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.
@ 2014-03-07 9:40 Denis Turischev
0 siblings, 0 replies; 8+ messages in thread
From: Denis Turischev @ 2014-03-07 9:40 UTC (permalink / raw)
To: Sarah Sharp, linux-usb; +Cc: Greg Kroah-Hartman, linux-kernel
The same issue like with Panther Point chipsets. If the USB ports are
switched to xHCI on shutdown, the xHCI host will send a spurious interrupt,
which will wake the system. Some BIOS have work around for this, but not all.
One example is Compulab's mini-desktop, the Intense-PC2.
The bug can be avoided if the USB ports are switched back to EHCI on
shutdown.
Signed-off-by: Denis Turischev <denis@compulab.co.il>
---
drivers/usb/host/xhci-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 3c898c1..9233d12 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -134,6 +134,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
*/
if (pdev->subsystem_vendor == PCI_VENDOR_ID_HP)
xhci->quirks |= XHCI_SPURIOUS_WAKEUP;
+
+ xhci->quirks |= XHCI_SPURIOUS_REBOOT;
}
if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
pdev->device == PCI_DEVICE_ID_ASROCK_P67) {
-- 1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.
@ 2014-03-09 12:43 Denis Turischev
0 siblings, 0 replies; 8+ messages in thread
From: Denis Turischev @ 2014-03-09 12:43 UTC (permalink / raw)
To: Sarah Sharp, Greg Kroah-Hartman; +Cc: linux-usb, linux-kernel
The same issue like with Panther Point chipsets. If the USB ports are
switched to xHCI on shutdown, the xHCI host will send a spurious interrupt,
which will wake the system. Some BIOS have work around for this, but not all.
One example is Compulab's mini-desktop, the Intense-PC2.
The bug can be avoided if the USB ports are switched back to EHCI on
shutdown.
Signed-off-by: Denis Turischev <denis@compulab.co.il>
---
drivers/usb/host/xhci-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 3c898c1..9233d12 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -134,6 +134,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
*/
if (pdev->subsystem_vendor == PCI_VENDOR_ID_HP)
xhci->quirks |= XHCI_SPURIOUS_WAKEUP;
+
+ xhci->quirks |= XHCI_SPURIOUS_REBOOT;
}
if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
pdev->device == PCI_DEVICE_ID_ASROCK_P67) {
-- 1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.
@ 2014-03-21 10:01 Denis Turischev
2014-03-21 12:10 ` Mathias Nyman
0 siblings, 1 reply; 8+ messages in thread
From: Denis Turischev @ 2014-03-21 10:01 UTC (permalink / raw)
To: Sarah Sharp; +Cc: Greg Kroah-Hartman, linux-kernel, linux-usb
The same issue like with Panther Point chipsets. If the USB ports are
switched to xHCI on shutdown, the xHCI host will send a spurious interrupt,
which will wake the system. Some BIOS have work around for this, but not all.
One example is Compulab's mini-desktop, the Intense-PC2.
The bug can be avoided if the USB ports are switched back to EHCI on
shutdown.
Signed-off-by: Denis Turischev <denis@compulab.co.il>
---
drivers/usb/host/xhci-pci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 3c898c1..9233d12 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -134,6 +134,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
*/
if (pdev->subsystem_vendor == PCI_VENDOR_ID_HP)
xhci->quirks |= XHCI_SPURIOUS_WAKEUP;
+
+ xhci->quirks |= XHCI_SPURIOUS_REBOOT;
}
if (pdev->vendor == PCI_VENDOR_ID_ETRON &&
pdev->device == PCI_DEVICE_ID_ASROCK_P67) {
-- 1.8.1.2
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.
2014-03-21 10:01 Denis Turischev
@ 2014-03-21 12:10 ` Mathias Nyman
2014-04-22 11:04 ` Denis Turischev
0 siblings, 1 reply; 8+ messages in thread
From: Mathias Nyman @ 2014-03-21 12:10 UTC (permalink / raw)
To: Denis Turischev, Sarah Sharp; +Cc: Greg Kroah-Hartman, linux-kernel, linux-usb
On 03/21/2014 12:01 PM, Denis Turischev wrote:
> The same issue like with Panther Point chipsets. If the USB ports are
> switched to xHCI on shutdown, the xHCI host will send a spurious interrupt,
> which will wake the system. Some BIOS have work around for this, but not all.
> One example is Compulab's mini-desktop, the Intense-PC2.
>
> The bug can be avoided if the USB ports are switched back to EHCI on
> shutdown.
>
I'll queue this up and send it forward to Greg once 3.15-rc1 is out
-Mathias
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.
2014-03-21 12:10 ` Mathias Nyman
@ 2014-04-22 11:04 ` Denis Turischev
2014-04-22 12:26 ` Mathias Nyman
0 siblings, 1 reply; 8+ messages in thread
From: Denis Turischev @ 2014-04-22 11:04 UTC (permalink / raw)
To: Mathias Nyman; +Cc: Greg Kroah-Hartman, linux-kernel, linux-usb
Hi Mathias,
Just want to remind you about the patch, thanks.
Denis
On 03/21/2014 02:10 PM, Mathias Nyman wrote:
> On 03/21/2014 12:01 PM, Denis Turischev wrote:
>> The same issue like with Panther Point chipsets. If the USB ports are
>> switched to xHCI on shutdown, the xHCI host will send a spurious interrupt,
>> which will wake the system. Some BIOS have work around for this, but not all.
>> One example is Compulab's mini-desktop, the Intense-PC2.
>>
>> The bug can be avoided if the USB ports are switched back to EHCI on
>> shutdown.
>>
>
> I'll queue this up and send it forward to Greg once 3.15-rc1 is out
>
> -Mathias
>
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown.
2014-04-22 11:04 ` Denis Turischev
@ 2014-04-22 12:26 ` Mathias Nyman
0 siblings, 0 replies; 8+ messages in thread
From: Mathias Nyman @ 2014-04-22 12:26 UTC (permalink / raw)
To: Denis Turischev; +Cc: Greg Kroah-Hartman, linux-kernel, linux-usb
On 04/22/2014 02:04 PM, Denis Turischev wrote:
> Hi Mathias,
>
> Just want to remind you about the patch, thanks.
>
>
Sent to Greg a minute ago, thanks
-Mathias
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-04-22 12:15 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-07 9:40 [RESEND] [PATCH] xhci: Switch Intel Lynx Point ports to EHCI on shutdown Denis Turischev
-- strict thread matches above, loose matches on Subject: below --
2014-03-21 10:01 Denis Turischev
2014-03-21 12:10 ` Mathias Nyman
2014-04-22 11:04 ` Denis Turischev
2014-04-22 12:26 ` Mathias Nyman
2014-03-09 12:43 Denis Turischev
2013-12-19 16:29 Denis Turischev
2014-02-04 11:10 ` [PATCH] " Denis Turischev
2014-02-18 7:42 ` [RESEND] " Denis Turischev
2014-02-18 18:54 ` Sarah Sharp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).