From: srinivas kandagatla <srinivas.kandagatla@st.com>
To: Maxime Coquelin <maxime.coquelin@st.com>,
Rob Landley <rob@landley.net>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Stuart Menefy <stuart.menefy@st.com>,
Linus Walleij <linus.walleij@linaro.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
<linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <kernel@stlinux.com>
Cc: <lee.jones@linaro.org>
Subject: Re: [PATCH v2 3/5] pinctrl: st: Enhance the controller to manage unavailable registers
Date: Fri, 7 Mar 2014 11:26:49 +0000 [thread overview]
Message-ID: <5319ACF9.4040504@st.com> (raw)
In-Reply-To: <5319AD5C.7050301@st.com>
On 07/03/14 11:28, Maxime Coquelin wrote:
>>
>
> Problem is that "oe" and "pu" takes -1 in that patch, and these values
> will be passed directly to devm_regmap_field_alloc without any check.
>
> I propose to apply this patch before "pinctrl: st: add pinctrl support
> for the STiH407 SoC", and move stih407_flashdata as you recommend.
>
> Is it fine for you?
Am OK with re-ordering, This will also be good for git bisect... :-)
Thanks,
srini
>
> Thanks for the review,
> Maxime
next prev parent reply other threads:[~2014-03-07 11:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 9:41 [PATCH v2 0/5] Add STiH407 SoC and reference board support Maxime COQUELIN
2014-03-07 9:41 ` [PATCH v2 1/5] ARM: STi: Add STiH407 SoC support Maxime COQUELIN
2014-03-07 9:41 ` [PATCH v2 2/5] pinctrl: st: add pinctrl support for the STiH407 SoC Maxime COQUELIN
2014-03-07 10:43 ` srinivas kandagatla
2014-03-07 9:41 ` [PATCH v2 3/5] pinctrl: st: Enhance the controller to manage unavailable registers Maxime COQUELIN
2014-03-07 10:37 ` srinivas kandagatla
2014-03-07 10:41 ` srinivas kandagatla
2014-03-07 11:28 ` Maxime Coquelin
2014-03-07 11:26 ` srinivas kandagatla [this message]
2014-03-07 9:41 ` [PATCH v2 4/5] ARM: dts: Add STiH407 SoC support Maxime COQUELIN
2014-03-07 9:41 ` [PATCH v2 5/5] ARM: dts: STiH407: Add B2120 board support Maxime COQUELIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5319ACF9.4040504@st.com \
--to=srinivas.kandagatla@st.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@stlinux.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.coquelin@st.com \
--cc=pawel.moll@arm.com \
--cc=peppe.cavallaro@st.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=stuart.menefy@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox