From: Jens Axboe <axboe@kernel.dk>
To: Mike Snitzer <snitzer@redhat.com>, Hannes Reinecke <hare@suse.de>
Cc: Mike Snitzer <snitzer@gmail.com>,
Christoph Hellwig <hch@infradead.org>,
Jeff Moyer <jmoyer@redhat.com>, Shaohua Li <shli@fusionio.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: fix q->flush_rq NULL pointer crash on dm-mpath flush
Date: Sat, 08 Mar 2014 17:24:09 -0700 [thread overview]
Message-ID: <531BB4A9.5000305@kernel.dk> (raw)
In-Reply-To: <20140308220926.GA15421@redhat.com>
On 2014-03-08 15:09, Mike Snitzer wrote:
> On Sat, Mar 08 2014 at 4:33pm -0500,
> Hannes Reinecke <hare@suse.de> wrote:
>
>> On 03/08/2014 07:13 PM, Mike Snitzer wrote:
>>>
>>> I'm calm.. was just a bit frustrated. But this isn't a big deal.
>>> I'll make an effort to reach out to relevant people sooner when
>>> similar stuff is reported against recently upstreamed code. Would be
>>> cool if you did the same. I can relate to needing to have the distro
>>> vendor hat on (first needing to determine/answer "is this issue
>>> specific to our hacked distro kernel?", etc).
>>>
>> The patch I made wasn't in the context of 'recently upstreamed
>> code', it was due to a backport Jan Kara did for our next distro
>> kernels (3.12-based).
>
> "3.12-based" means nothing given all the backporting for SLES, much like
> "3.10-based" means nothing in the context of RHEL7.
>
> The only way this fix is applicable is in the context of "recently
> upstreamed code", commit 1874198 ("blk-mq: rework flush sequencing
> logic") went upstream for v3.14-rc3.
>
> Jens, please feel free to queue this tested fix for 3.14-rc:
Thanks Mike, queued up. Also queued up the list addition reversal change.
--
Jens Axboe
next prev parent reply other threads:[~2014-03-09 0:24 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 13:26 [PATCH 0/1] block: rework flush sequencing for blk-mq Christoph Hellwig
2014-01-30 13:26 ` [PATCH 1/1] " Christoph Hellwig
2014-02-07 1:18 ` Shaohua Li
2014-02-07 14:19 ` Christoph Hellwig
2014-02-08 0:55 ` Shaohua Li
2014-02-10 10:33 ` Christoph Hellwig
2014-03-07 20:45 ` Jeff Moyer
2014-03-08 15:52 ` Christoph Hellwig
2014-03-08 17:33 ` Mike Snitzer
2014-03-08 19:51 ` Hannes Reinecke
2014-03-08 18:13 ` Mike Snitzer
2014-03-08 21:33 ` Hannes Reinecke
2014-03-08 22:09 ` [PATCH] block: fix q->flush_rq NULL pointer crash on dm-mpath flush Mike Snitzer
2014-03-09 0:24 ` Jens Axboe [this message]
2014-03-09 0:57 ` Mike Snitzer
2014-03-09 3:18 ` Jens Axboe
2014-03-09 3:29 ` Mike Snitzer
2014-03-12 10:28 ` [PATCH 1/1] block: rework flush sequencing for blk-mq Christoph Hellwig
2014-03-12 10:50 ` Hannes Reinecke
2014-03-12 10:55 ` Christoph Hellwig
2014-03-12 11:07 ` Hannes Reinecke
2014-03-12 11:00 ` SuSE O_DIRECT|O_NONBLOCK overload Christoph Hellwig
2014-03-13 0:15 ` NeilBrown
2014-03-14 17:46 ` Mike Christie
2014-03-13 16:13 ` [PATCH 1/1] block: rework flush sequencing for blk-mq Mike Snitzer
2014-03-14 9:25 ` Christoph Hellwig
2014-03-14 9:30 ` Hannes Reinecke
2014-03-14 12:44 ` Christoph Hellwig
2014-03-14 9:34 ` Christoph Hellwig
2014-03-14 9:52 ` Hannes Reinecke
2014-03-14 10:58 ` Christoph Hellwig
2014-03-14 11:10 ` Hannes Reinecke
2014-03-14 13:00 ` Mike Snitzer
2014-03-14 13:23 ` Christoph Hellwig
2014-03-14 14:13 ` Mike Snitzer
2014-03-15 13:28 ` scsi_debug and mutipath, was " Christoph Hellwig
2014-03-17 11:55 ` [dm-devel] " Bryn M. Reeves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531BB4A9.5000305@kernel.dk \
--to=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=jmoyer@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@fusionio.com \
--cc=snitzer@gmail.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).