From: Lars-Peter Clausen <lars@metafoo.de>
To: "Li.Xiubo@freescale.com" <Li.Xiubo@freescale.com>
Cc: Mark Brown <broonie@kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [alsa-devel] [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.
Date: Mon, 10 Mar 2014 07:57:38 +0100 [thread overview]
Message-ID: <531D6262.3070201@metafoo.de> (raw)
In-Reply-To: <0dbba1debfd149a6a5e3985349a95793@BY2PR03MB505.namprd03.prod.outlook.com>
On 03/10/2014 04:51 AM, Li.Xiubo@freescale.com wrote:
>> Subject: Re: [PATCHv3 1/3] ASoC: codec: Simplify ASoC probe code.
>>
>> On Mon, Mar 03, 2014 at 07:24:36AM +0000, Li.Xiubo@freescale.com wrote:
>>
>>>>> /* Default to using ALC auto offset calibration mode. */
>>>>> snd_soc_update_bits(codec, DA7213_ALC_CTRL1,
>>>>> DA7213_ALC_CALIB_MODE_MAN, 0);
>>
>>>> This one will fail.
>>
>>> Sorry, I'm not very understand why will this fail ? Before the ASoC probe,
>>> the ASoC core will set the I/O.
>>> :)
>>
>> OK, that's now been refactored.
>
> @Mark, @Lars,
>
> Has there any other problems about this patch series? And this I had tested on
> our Vybrid-Twr board based on SGTL5000 codec and SAI drivers. If not, I can
> continue with my second patches series about " Remove set_cache_io entirely from
> ASoC probe".
>
> Thanks very much.
>
It looks good to me.
next prev parent reply other threads:[~2014-03-10 6:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 2:42 [PATCHv3 0/3] Simplify the CODEC ASoC probe code Xiubo Li
2014-03-03 2:42 ` [PATCHv3 1/3] ASoC: codec: Simplify " Xiubo Li
2014-03-03 4:59 ` Mark Brown
2014-03-03 7:24 ` Li.Xiubo
2014-03-04 4:36 ` Mark Brown
2014-03-10 3:51 ` Li.Xiubo
2014-03-10 6:57 ` Lars-Peter Clausen [this message]
2014-03-10 7:38 ` [alsa-devel] " Mark Brown
2014-03-10 7:47 ` Lars-Peter Clausen
2014-03-10 7:56 ` Li.Xiubo
2014-03-10 14:54 ` Timur Tabi
2014-03-03 2:42 ` [PATCHv3 2/3] ASoC: io: New signature for snd_soc_codec_set_cache_io() Xiubo Li
2014-03-03 2:42 ` [PATCHv3 3/3] ASoC: core: Fix check before setting default I/O up try regmap Xiubo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531D6262.3070201@metafoo.de \
--to=lars@metafoo.de \
--cc=Li.Xiubo@freescale.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox