From: "Fernando Luis Vázquez Cao" <fernando_b1@lab.ntt.co.jp>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Ingo Molnar <mingo@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sched/clock: prevent tracing recursion in sched_clock_cpu()
Date: Mon, 10 Mar 2014 16:17:18 +0900 [thread overview]
Message-ID: <531D66FE.20703@lab.ntt.co.jp> (raw)
In-Reply-To: <20140306055113.2306397d@gandalf.local.home>
On 03/06/2014 07:51 PM, Steven Rostedt wrote:
> On Thu, 06 Mar 2014 14:25:28 +0900
> Fernando Luis Vázquez Cao <fernando_b1@lab.ntt.co.jp> wrote:
>
>> From: Fernando Luis Vazquez Cao <fernando@oss.ntt.co.jp>
>>
>> Prevent tracing of preempt_disable/enable() in sched_clock_cpu().
>> When CONFIG_DEBUG_PREEMPT is enabled, preempt_disable/enable() are
>> traced and this causes trace_clock() users (and probably others) to
>> go into an infinite recursion. Systems with a stable sched_clock()
>> are not affected.
>>
>> This problem is similar to that fixed by upstream commit 95ef1e52922
>> ("KVM guest: prevent tracing recursion with kvmclock").
> Also similar to: 569d6557ab957.
>
> Acked-by: Steven Rostedt <rostedt@goodmis.org>
Thank you four your review, Peter, Steven.
By the way, who is going to pick this patch? Do you want
me to resend with Steven's Acked-by added?
- Fernando
next prev parent reply other threads:[~2014-03-10 7:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 5:25 [PATCH] sched/clock: prevent tracing recursion in sched_clock_cpu() Fernando Luis Vázquez Cao
2014-03-06 10:51 ` Steven Rostedt
2014-03-10 7:17 ` Fernando Luis Vázquez Cao [this message]
2014-03-11 3:47 ` Steven Rostedt
2014-03-11 8:15 ` Peter Zijlstra
2014-03-06 10:51 ` Peter Zijlstra
2014-03-11 12:36 ` [tip:sched/core] sched/clock: Prevent " tip-bot for Fernando Luis Vazquez Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531D66FE.20703@lab.ntt.co.jp \
--to=fernando_b1@lab.ntt.co.jp \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox