[PATCH] score: remove unused CPU_SCORE7 Kconfig parameter

[PATCH] score: remove unused CPU_SCORE7 Kconfig parameter

[Michael Opdenacker]

This removes the CPU_SCORE7 Kconfig parameter,
which was no longer used anywhere in the source code
and Makefiles.

Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
---
 arch/score/Kconfig | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/score/Kconfig b/arch/score/Kconfig
index 305f7ee1f382..2bc03d04f3af 100644
--- a/arch/score/Kconfig
+++ b/arch/score/Kconfig
@@ -23,27 +23,21 @@ choice
 config ARCH_SCORE7
 	bool "SCORE7 processor"
 	select SYS_SUPPORTS_32BIT_KERNEL
-	select CPU_SCORE7
 	select GENERIC_HAS_IOMAP
 
 config MACH_SPCT6600
 	bool "SPCT6600 series based machines"
 	select SYS_SUPPORTS_32BIT_KERNEL
-	select CPU_SCORE7
 	select GENERIC_HAS_IOMAP
 
 config SCORE_SIM
 	bool "Score simulator"
 	select SYS_SUPPORTS_32BIT_KERNEL
-	select CPU_SCORE7
 	select GENERIC_HAS_IOMAP
 endchoice
 
 endmenu
 
-config CPU_SCORE7
-	bool
-
 config NO_DMA
 	bool
 	default y
-- 
1.8.1.2

Re: [PATCH] score: remove unused CPU_SCORE7 Kconfig parameter

[Lennox Wu]

Hi Michael,
We have another processor, the parameter will be used to differentiate
the different processors.
Anyway, thank you. :)

Best,
Lennox


2013/11/4 Michael Opdenacker <michael.opdenacker@free-electrons.com>:
> This removes the CPU_SCORE7 Kconfig parameter,
> which was no longer used anywhere in the source code
> and Makefiles.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> ---
>  arch/score/Kconfig | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/arch/score/Kconfig b/arch/score/Kconfig
> index 305f7ee1f382..2bc03d04f3af 100644
> --- a/arch/score/Kconfig
> +++ b/arch/score/Kconfig
> @@ -23,27 +23,21 @@ choice
>  config ARCH_SCORE7
>         bool "SCORE7 processor"
>         select SYS_SUPPORTS_32BIT_KERNEL
> -       select CPU_SCORE7
>         select GENERIC_HAS_IOMAP
>
>  config MACH_SPCT6600
>         bool "SPCT6600 series based machines"
>         select SYS_SUPPORTS_32BIT_KERNEL
> -       select CPU_SCORE7
>         select GENERIC_HAS_IOMAP
>
>  config SCORE_SIM
>         bool "Score simulator"
>         select SYS_SUPPORTS_32BIT_KERNEL
> -       select CPU_SCORE7
>         select GENERIC_HAS_IOMAP
>  endchoice
>
>  endmenu
>
> -config CPU_SCORE7
> -       bool
> -
>  config NO_DMA
>         bool
>         default y
> --
> 1.8.1.2
>

Re: [PATCH] score: remove unused CPU_SCORE7 Kconfig parameter

[Michael Opdenacker]

Hi Lennox,

Thank you very much for reviewing my patch!

On 11/04/2013 03:52 PM, Lennox Wu wrote:
> Hi Michael,
> We have another processor, the parameter will be used to differentiate
> the different processors.

I understand, no problem! As long as this is fine for you, that's fine
for me too :)
> Anyway, thank you. :)

You are very welcome.

Cheers,

Michael.

-- 
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098

[PATCH][RESEND] score: remove unused CPU_SCORE7 Kconfig parameter

[Michael Opdenacker]

This removes the CPU_SCORE7 Kconfig parameter,
which was no longer used anywhere in the source code
and Makefiles.

Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
---
 arch/score/Kconfig | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/score/Kconfig b/arch/score/Kconfig
index 305f7ee1f382..2bc03d04f3af 100644
--- a/arch/score/Kconfig
+++ b/arch/score/Kconfig
@@ -23,27 +23,21 @@ choice
 config ARCH_SCORE7
 	bool "SCORE7 processor"
 	select SYS_SUPPORTS_32BIT_KERNEL
-	select CPU_SCORE7
 	select GENERIC_HAS_IOMAP
 
 config MACH_SPCT6600
 	bool "SPCT6600 series based machines"
 	select SYS_SUPPORTS_32BIT_KERNEL
-	select CPU_SCORE7
 	select GENERIC_HAS_IOMAP
 
 config SCORE_SIM
 	bool "Score simulator"
 	select SYS_SUPPORTS_32BIT_KERNEL
-	select CPU_SCORE7
 	select GENERIC_HAS_IOMAP
 endchoice
 
 endmenu
 
-config CPU_SCORE7
-	bool
-
 config NO_DMA
 	bool
 	default y
-- 
1.8.3.2

[PATCH] [RESEND] score: remove unused CPU_SCORE7 Kconfig parameter

[Michael Opdenacker]

This removes the CPU_SCORE7 Kconfig parameter,
which is no longer used anywhere in the source code
and Makefiles.

Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
---
 arch/score/Kconfig | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/arch/score/Kconfig b/arch/score/Kconfig
index c75d06aa27c3..4ac8cae5727c 100644
--- a/arch/score/Kconfig
+++ b/arch/score/Kconfig
@@ -22,27 +22,21 @@ choice
 config ARCH_SCORE7
 	bool "SCORE7 processor"
 	select SYS_SUPPORTS_32BIT_KERNEL
-	select CPU_SCORE7
 	select GENERIC_HAS_IOMAP
 
 config MACH_SPCT6600
 	bool "SPCT6600 series based machines"
 	select SYS_SUPPORTS_32BIT_KERNEL
-	select CPU_SCORE7
 	select GENERIC_HAS_IOMAP
 
 config SCORE_SIM
 	bool "Score simulator"
 	select SYS_SUPPORTS_32BIT_KERNEL
-	select CPU_SCORE7
 	select GENERIC_HAS_IOMAP
 endchoice
 
 endmenu
 
-config CPU_SCORE7
-	bool
-
 config NO_DMA
 	bool
 	default y
-- 
1.8.3.2

Re: [PATCH] [RESEND] score: remove unused CPU_SCORE7 Kconfig parameter

[Lennox Wu]

HI Michael,
According to my record, I had told you we have another
processor(2013/11/4), hence, we need the parameter.
We just wirte it done first. Do you remember it?

Best,
Lennox


2014-03-08 13:26 GMT+08:00 Michael Opdenacker
<michael.opdenacker@free-electrons.com>:
> This removes the CPU_SCORE7 Kconfig parameter,
> which is no longer used anywhere in the source code
> and Makefiles.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> ---
>  arch/score/Kconfig | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/arch/score/Kconfig b/arch/score/Kconfig
> index c75d06aa27c3..4ac8cae5727c 100644
> --- a/arch/score/Kconfig
> +++ b/arch/score/Kconfig
> @@ -22,27 +22,21 @@ choice
>  config ARCH_SCORE7
>         bool "SCORE7 processor"
>         select SYS_SUPPORTS_32BIT_KERNEL
> -       select CPU_SCORE7
>         select GENERIC_HAS_IOMAP
>
>  config MACH_SPCT6600
>         bool "SPCT6600 series based machines"
>         select SYS_SUPPORTS_32BIT_KERNEL
> -       select CPU_SCORE7
>         select GENERIC_HAS_IOMAP
>
>  config SCORE_SIM
>         bool "Score simulator"
>         select SYS_SUPPORTS_32BIT_KERNEL
> -       select CPU_SCORE7
>         select GENERIC_HAS_IOMAP
>  endchoice
>
>  endmenu
>
> -config CPU_SCORE7
> -       bool
> -
>  config NO_DMA
>         bool
>         default y
> --
> 1.8.3.2
>

Re: [PATCH] [RESEND] score: remove unused CPU_SCORE7 Kconfig parameter

[Paul Bolle]

Lennox,

On Sat, 2014-03-08 at 14:34 +0800, Lennox Wu wrote:
> According to my record, I had told you we have another
> processor(2013/11/4), hence, we need the parameter.
> We just wirte it done first. Do you remember it?

In https://lkml.org/lkml/2011/11/12/76 I already reported that this
Kconfig symbol was unused. Why can't it be dropped and re-added when
code is added to the tree that actually uses it?


Paul Bolle

Re: [PATCH] [RESEND] score: remove unused CPU_SCORE7 Kconfig parameter

[Lennox Wu]

Because I don't think droping it is meaningful, since it will be used.
Moreover, the symbol never affect other architectures or subsystems.
I feel that is not good to brother people to process the unimportant patch.

Best,
Lennox


2014-03-09 4:00 GMT+08:00 Paul Bolle <pebolle@tiscali.nl>:
> Lennox,
>
> On Sat, 2014-03-08 at 14:34 +0800, Lennox Wu wrote:
>> According to my record, I had told you we have another
>> processor(2013/11/4), hence, we need the parameter.
>> We just wirte it done first. Do you remember it?
>
> In https://lkml.org/lkml/2011/11/12/76 I already reported that this
> Kconfig symbol was unused. Why can't it be dropped and re-added when
> code is added to the tree that actually uses it?
>
>
> Paul Bolle
>

Re: [PATCH] [RESEND] score: remove unused CPU_SCORE7 Kconfig parameter

[Paul Bolle]

On Sun, 2014-03-09 at 04:27 +0800, Lennox Wu wrote:
> 2014-03-09 4:00 GMT+08:00 Paul Bolle <pebolle@tiscali.nl>:
> > In https://lkml.org/lkml/2011/11/12/76 I already reported that this
> > Kconfig symbol was unused. Why can't it be dropped and re-added when
> > code is added to the tree that actually uses it?
>
> Because I don't think droping it is meaningful, since it will be used.

But, again, it isn't used now and hasn't actually been used in years.

> Moreover, the symbol never affect other architectures or subsystems.
> I feel that is not good to brother people to process the unimportant patch.

Sure, this is just a small cleanup. But the scripts people use to see
whether more serious Kconfig related issues have entered the tree will
likely notice CPU_SCORE7. (And those people will have to investigate why
that symbol is unused - which might take quite a bit of work - to
determine what needs to be done about it.) So whenever someone, not
following this thread, runs a script like that the score maintainers
might receive a similar patch again.

And I don't believe that handling a single cleanup patch is particularly
burdensome for the score maintainers.


Paul Bolle

Re: [PATCH] [RESEND] score: remove unused CPU_SCORE7 Kconfig parameter

[Lennox Wu]

Actually, people I don't want to brother are guys intergrate all
patches on the maillist.
There are too many patches whaic are waiting they to process.
I will check the development progress of the another Score and
consider if we should remove the config.
Thanks for your suggestion.

Best,
Lennox

2014-03-09 5:02 GMT+08:00 Paul Bolle <pebolle@tiscali.nl>:
> On Sun, 2014-03-09 at 04:27 +0800, Lennox Wu wrote:
>> 2014-03-09 4:00 GMT+08:00 Paul Bolle <pebolle@tiscali.nl>:
>> > In https://lkml.org/lkml/2011/11/12/76 I already reported that this
>> > Kconfig symbol was unused. Why can't it be dropped and re-added when
>> > code is added to the tree that actually uses it?
>>
>> Because I don't think droping it is meaningful, since it will be used.
>
> But, again, it isn't used now and hasn't actually been used in years.
>
>> Moreover, the symbol never affect other architectures or subsystems.
>> I feel that is not good to brother people to process the unimportant patch.
>
> Sure, this is just a small cleanup. But the scripts people use to see
> whether more serious Kconfig related issues have entered the tree will
> likely notice CPU_SCORE7. (And those people will have to investigate why
> that symbol is unused - which might take quite a bit of work - to
> determine what needs to be done about it.) So whenever someone, not
> following this thread, runs a script like that the score maintainers
> might receive a similar patch again.
>
> And I don't believe that handling a single cleanup patch is particularly
> burdensome for the score maintainers.
>
>
> Paul Bolle
>

Re: [PATCH] [RESEND] score: remove unused CPU_SCORE7 Kconfig parameter

[Michael Opdenacker]

On 03/08/2014 07:34 AM, Lennox Wu wrote:
> HI Michael,
> According to my record, I had told you we have another
> processor(2013/11/4), hence, we need the parameter.
> We just wirte it done first. Do you remember it?
Hi Lennox,

I missed your reply because it got deleted by mistake. My apologies!

However, I agree with Paul in the sense that keeping such a parameter
for a long time before it is actually used just adds some unnecessary
noise, hiding the parameters that would really need removing.

And indeed, it will be hard to stop other people from reporting this
again in the future...

Thank you for your replies.

Cheers,

Michael.

-- 
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098