From: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Pavel Machek <pavel@ucw.cz>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@linux-m68k.org>
Subject: Re: [PATCH v2] PM: Add missing "freeze" state
Date: Tue, 11 Mar 2014 16:41:58 +0530 [thread overview]
Message-ID: <531EEF7E.20107@linux.vnet.ibm.com> (raw)
In-Reply-To: <1394536091-28881-1-git-send-email-geert@linux-m68k.org>
On 03/11/2014 04:38 PM, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Regards,
Srivatsa S. Bhat
> ---
> v2:
> - Update comments for state_show() as suggested by Srivatsa S. Bhat
> <srivatsa.bhat@linux.vnet.ibm.com>
>
> Documentation/ABI/testing/sysfs-power | 5 +++--
> kernel/power/main.c | 4 ++--
> 2 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-power b/Documentation/ABI/testing/sysfs-power
> index 205a73878441..64c9276e9421 100644
> --- a/Documentation/ABI/testing/sysfs-power
> +++ b/Documentation/ABI/testing/sysfs-power
> @@ -12,8 +12,9 @@ Contact: Rafael J. Wysocki <rjw@rjwysocki.net>
> Description:
> The /sys/power/state file controls the system power state.
> Reading from this file returns what states are supported,
> - which is hard-coded to 'standby' (Power-On Suspend), 'mem'
> - (Suspend-to-RAM), and 'disk' (Suspend-to-Disk).
> + which is hard-coded to 'freeze' (Low-Power Idle), 'standby'
> + (Power-On Suspend), 'mem' (Suspend-to-RAM), and 'disk'
> + (Suspend-to-Disk).
>
> Writing to this file one of these strings causes the system to
> transition into that state. Please see the file
> diff --git a/kernel/power/main.c b/kernel/power/main.c
> index 1d1bf630e6e9..6271bc4073ef 100644
> --- a/kernel/power/main.c
> +++ b/kernel/power/main.c
> @@ -282,8 +282,8 @@ struct kobject *power_kobj;
> * state - control system power state.
> *
> * show() returns what states are supported, which is hard-coded to
> - * 'standby' (Power-On Suspend), 'mem' (Suspend-to-RAM), and
> - * 'disk' (Suspend-to-Disk).
> + * 'freeze' (Low-Power Idle), 'standby' (Power-On Suspend),
> + * 'mem' (Suspend-to-RAM), and 'disk' (Suspend-to-Disk).
> *
> * store() accepts one of those strings, translates it into the
> * proper enumerated value, and initiates a suspend transition.
>
next prev parent reply other threads:[~2014-03-11 11:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 11:08 [PATCH v2] PM: Add missing "freeze" state Geert Uytterhoeven
2014-03-11 11:11 ` Srivatsa S. Bhat [this message]
2014-03-11 12:40 ` Pavel Machek
2014-03-11 13:13 ` Geert Uytterhoeven
2014-03-12 0:13 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531EEF7E.20107@linux.vnet.ibm.com \
--to=srivatsa.bhat@linux.vnet.ibm.com \
--cc=geert+renesas@linux-m68k.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox