From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Chew Chiau Ee <chiau.ee.chew@intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Darren Hart <dvhart@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl-baytrail: add function mux checking in gpio pin request
Date: Tue, 11 Mar 2014 13:48:23 +0200 [thread overview]
Message-ID: <531EF807.8080005@linux.intel.com> (raw)
In-Reply-To: <CACRpkdajaffBOmc9KeUyLkwZth6vNu-Z0Ln+Xf4ZV0gZ9Ytf_g@mail.gmail.com>
On 03/11/2014 12:27 PM, Linus Walleij wrote:
> On Thu, Mar 6, 2014 at 2:59 PM, Chew Chiau Ee <chiau.ee.chew@intel.com> wrote:
>
>> From: Chew, Kean Ho <kean.ho.chew@intel.com>
>>
>> The requested gpio pin must has the func_pin_mux field set
>> to GPIO function by BIOS/FW in advanced. Else, the gpio pin
>> request would fail. This is to ensure that we do not expose
>> any gpio pins which shall be used for alternate functions,
>> for eg: wakeup pin, I/O interfaces for LPSS, etc.
>>
>> Signed-off-by: Chew, Kean Ho <kean.ho.chew@intel.com>
>> Signed-off-by: Chew, Chiau Ee <chiau.ee.chew@intel.com>
>
> Patch applied with Darren's ACK.
>
> This confirms my suspicion that you will not be able to
> hide the pin control interface side of this hardware forever. ;-)
Hate to admit it but so it seems :)
>
> Mika/Mathias: any comments?
Patch looks fine
Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
-Mathias
prev parent reply other threads:[~2014-03-11 11:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 13:59 [PATCH] pinctrl-baytrail: add function mux checking in gpio pin request Chew Chiau Ee
2014-03-06 6:56 ` Darren Hart
2014-03-11 10:27 ` Linus Walleij
2014-03-11 10:36 ` Mika Westerberg
2014-03-11 11:48 ` Mathias Nyman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531EF807.8080005@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=chiau.ee.chew@intel.com \
--cc=dvhart@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox