From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754874AbaCKMQU (ORCPT ); Tue, 11 Mar 2014 08:16:20 -0400 Received: from eu1sys200aog111.obsmtp.com ([207.126.144.131]:33765 "EHLO eu1sys200aog111.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752853AbaCKMQS (ORCPT ); Tue, 11 Mar 2014 08:16:18 -0400 Message-ID: <531EFE75.9010709@st.com> Date: Tue, 11 Mar 2014 13:15:49 +0100 From: Maxime Coquelin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Lee Jones Cc: , , Subject: Re: [PATCH 1/3] ARM: DT: STi: Add support to B2020 revision E board. References: <1394533324-20299-1-git-send-email-lee.jones@linaro.org> <531EEA39.50504@st.com> <20140311112342.GE21216@lee--X1> In-Reply-To: <20140311112342.GE21216@lee--X1> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.201.23.80] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/11/2014 12:23 PM, Lee Jones wrote: >>> From: Srinivas Kandagatla >>> >>> This patch adds support to rev E board of B2020 which has few minor >>> changes : >>> PHY reset PIO (Change from PIO30 to PIO07) >>> Power LED(Green) Control(Change from PIO47 to PIO13) >> >> I thought we decided last October to support only one revision of >> the b2020 board. >> >> The idea was to create an external git to provide DTS for all our >> boards, and only have a minimal subset in in the kernel. > > Ah, I was unaware of that conversation/decision. If that's the case we > can scrap this submission along with the following patch. In fact we had the discussion together with Arnd (IIRC) on #armlinux :) The reason is we wanted to avoid flooding arch/arm/dts/ with all the possible combinations of board revisions. The idea was to put in place a git repository at stlinux.com to provide the DTS for all the STi boards, and try to keep arch/arm/dts/sti* simple. > > JOOI, what happens if I want to boot Mainline on my revE board? It > won't be fully functional will it? That will be a shame. The LEDs, not > so much, but networking is a pretty big piece of functionality to > lose. I agree this is not comfortable. The problem is that your patch is not enough. We would need to create much more files, because for example, the i2c used are not the same between rev. C and rev. E. It gives theses files only for b2020 support: arch/arm/boot/dts/stih415-b2020.dts arch/arm/boot/dts/stih416-b2020e.dts arch/arm/boot/dts/stih41x-b2020e.dtsi arch/arm/boot/dts/stih416-b2020.dts arch/arm/boot/dts/stih41x-b2020.dtsi arch/arm/boot/dts/stih41x-b2020x.dtsi Regards, Maxime