From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755095AbaCKMeL (ORCPT ); Tue, 11 Mar 2014 08:34:11 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:22385 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752853AbaCKMeJ (ORCPT ); Tue, 11 Mar 2014 08:34:09 -0400 X-AuditID: cbfec7f4-b7f796d000005a13-c1-531f02be8de5 Message-id: <531F02B0.6060302@samsung.com> Date: Tue, 11 Mar 2014 13:33:52 +0100 From: Tomasz Figa User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.1 MIME-version: 1.0 To: Chanwoo Choi , kgene.kim@samsung.com Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kyungmin.park@samsung.com, rob.herring@calxeda.com, pawel.moll@arm.com, mark.rutland@arm.com, swarren@wwwdotorg.org, ijc+devicetree@hellion.org.uk, linux@arm.linux.org.uk Subject: Re: [PATCH 4/5] ARM: dts: exynos: Move common dt data for interrupt combiner controller References: <1394524494-30641-1-git-send-email-cw00.choi@samsung.com> <1394524494-30641-5-git-send-email-cw00.choi@samsung.com> In-reply-to: <1394524494-30641-5-git-send-email-cw00.choi@samsung.com> Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsVy+t/xy7r7mOSDDZavk7S4/uU5q8X8I+dY Lc69Wslo0bvgKpvF2aY37BabHl9jtbi8aw6bxYzz+5gsbl/mtVh6/SKTxYTpa1ksDq84wGTx 6mAbiwOvx5p5axg9Wpp72DwWfL7C7rFy+Rc2j81L6j36tqxi9Pi8Sc5j49zQAI4oLpuU1JzM stQifbsEroz1T5axFdyXqnj+rJWxgfGgSBcjJ4eEgInEnSsf2SFsMYkL99azdTFycQgJLGWU mLl/O1hCSOAzo8SxxdIgNq+AlsTauyuZQGwWAVWJd58awGw2ATWJzw2P2EBsUYEIib/z1jNC 1AtK/Jh8jwXEFhGwl9jzYAMjyAJmgZ1MEnuW7gRrFhZIktiy7hkrxLJGRolJLeogNqeAm8Tf 1jawGmYBa4mVk7YxQtjyEpvXvGWewCgwC8mOWUjKZiEpW8DIvIpRNLU0uaA4KT3XUK84Mbe4 NC9dLzk/dxMjJHa+7GBcfMzqEKMAB6MSD+8Kf7lgIdbEsuLK3EOMEhzMSiK8F+8BhXhTEiur Uovy44tKc1KLDzEycXBKNTCyz7qjo/zRdO/chOZAIUXW7T0xIdePzO2v7XNa9ynD4sq/w1W6 MTn5LbEKXx8GL77Gs+fDuT1/VuwoDP71+9SMje/e2YqfeHfXuXpN/kGrmnjHnzxLin9zH//+ sXj/eaVV73USRCKuGctHLFv3Wq30Z8SOXtvVb1aLlwmJeaskXyhz3eIs83CaEktxRqKhFnNR cSIA9KnGgnsCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chanwoo, On 11.03.2014 08:54, Chanwoo Choi wrote: > This patch move common dt data of interrupt combiner controller to > exynos4x12.dtsi. Each Exynos4x12 SoC has different number of interrput combiner > as following: > - Exynos4212 : interrput combiner 18(0 ~ 17) > - Exynos4412 : interrput combiner 20(0 ~ 19) > > The exynos combiner driver initialize interrupt according to specific number > of interrput combiner. > - samsung,combiner-nr : The number of interrput combiners supported. > > Also, > This patch arrange again the dt data according to register address > in exynos4212/exynos4412.dtsi. > > Signed-off-by: Chanwoo Choi > Signed-off-by: Kyungmin Park > --- > arch/arm/boot/dts/exynos4212.dtsi | 13 ++++--------- > arch/arm/boot/dts/exynos4412.dtsi | 14 ++++---------- > arch/arm/boot/dts/exynos4x12.dtsi | 8 ++++++++ > 3 files changed, 16 insertions(+), 19 deletions(-) Reviewed-by: Tomasz Figa Best regards, Tomasz > diff --git a/arch/arm/boot/dts/exynos4212.dtsi b/arch/arm/boot/dts/exynos4212.dtsi > index 94a43f9..ceefc71 100644 > --- a/arch/arm/boot/dts/exynos4212.dtsi > +++ b/arch/arm/boot/dts/exynos4212.dtsi > @@ -22,16 +22,11 @@ > / { > compatible = "samsung,exynos4212"; > > - gic: interrupt-controller@10490000 { > - cpu-offset = <0x8000>; > + combiner: interrupt-controller@10440000 { > + samsung,combiner-nr = <18>; > }; > > - interrupt-controller@10440000 { > - samsung,combiner-nr = <18>; > - interrupts = <0 0 0>, <0 1 0>, <0 2 0>, <0 3 0>, > - <0 4 0>, <0 5 0>, <0 6 0>, <0 7 0>, > - <0 8 0>, <0 9 0>, <0 10 0>, <0 11 0>, > - <0 12 0>, <0 13 0>, <0 14 0>, <0 15 0>, > - <0 107 0>, <0 108 0>; > + gic: interrupt-controller@10490000 { > + cpu-offset = <0x8000>; > }; > }; > diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi > index 87b339c..a40b6e2 100644 > --- a/arch/arm/boot/dts/exynos4412.dtsi > +++ b/arch/arm/boot/dts/exynos4412.dtsi > @@ -22,17 +22,11 @@ > / { > compatible = "samsung,exynos4412"; > > - gic: interrupt-controller@10490000 { > - cpu-offset = <0x4000>; > - }; > - > - interrupt-controller@10440000 { > + combiner: interrupt-controller@10440000 { > samsung,combiner-nr = <20>; > - interrupts = <0 0 0>, <0 1 0>, <0 2 0>, <0 3 0>, > - <0 4 0>, <0 5 0>, <0 6 0>, <0 7 0>, > - <0 8 0>, <0 9 0>, <0 10 0>, <0 11 0>, > - <0 12 0>, <0 13 0>, <0 14 0>, <0 15 0>, > - <0 107 0>, <0 108 0>, <0 48 0>, <0 42 0>; > }; > > + gic: interrupt-controller@10490000 { > + cpu-offset = <0x4000>; > + }; > }; > diff --git a/arch/arm/boot/dts/exynos4x12.dtsi b/arch/arm/boot/dts/exynos4x12.dtsi > index 066eb35..6e17034 100644 > --- a/arch/arm/boot/dts/exynos4x12.dtsi > +++ b/arch/arm/boot/dts/exynos4x12.dtsi > @@ -73,6 +73,14 @@ > }; > }; > > + combiner: interrupt-controller@10440000 { > + interrupts = <0 0 0>, <0 1 0>, <0 2 0>, <0 3 0>, > + <0 4 0>, <0 5 0>, <0 6 0>, <0 7 0>, > + <0 8 0>, <0 9 0>, <0 10 0>, <0 11 0>, > + <0 12 0>, <0 13 0>, <0 14 0>, <0 15 0>, > + <0 107 0>, <0 108 0>, <0 48 0>, <0 42 0>; > + }; > + > pinctrl_0: pinctrl@11400000 { > compatible = "samsung,exynos4x12-pinctrl"; > reg = <0x11400000 0x1000>; >