From: Ian Abbott <abbotti@mev.co.uk>
To: Conrad Meyer <cemeyer@uw.edu>, Greg Kroah-Hartman <greg@kroah.com>
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] Staging: comedi: Fix some raw printks with dev_warn()
Date: Tue, 11 Mar 2014 14:19:34 +0000 [thread overview]
Message-ID: <531F1B76.6010608@mev.co.uk> (raw)
In-Reply-To: <20140308214239.36a60185@m>
On 2014-03-09 02:42, Conrad Meyer wrote:
> Brought to you with the help of sed and manual clean-up after.
>
> $ sed -i -e 's|printk("\\n|dev_warn(dev->hw_dev,\n\t"|' \
> addi-data/hwdrv_apci1500.c
>
> Since all of these printk()s were for invalid API inputs and most of
> them returned -EINVAL, I fixed the rest of them to return -EINVAL as
> well.
>
> Signed-off-by: Conrad Meyer <cse.cem@gmail.com>
In comedi, we usually use dev->class_dev as the device for these sorts
of messages.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
next prev parent reply other threads:[~2014-03-11 14:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-09 2:42 [PATCH 1/3] Staging: comedi: Fix some raw printks with dev_warn() Conrad Meyer
2014-03-11 14:19 ` Ian Abbott [this message]
2014-03-11 14:58 ` [PATCH] Staging: comedi: fixup: dev_warn() with correct dev Conrad Meyer
2014-03-11 15:22 ` Ian Abbott
2014-03-17 21:00 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531F1B76.6010608@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=cemeyer@uw.edu \
--cc=devel@driverdev.osuosl.org \
--cc=greg@kroah.com \
--cc=hsweeten@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox