From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753651AbaCKPzf (ORCPT ); Tue, 11 Mar 2014 11:55:35 -0400 Received: from smtp-out-101.synserver.de ([212.40.185.101]:1057 "EHLO smtp-out-129.synserver.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752248AbaCKPzd (ORCPT ); Tue, 11 Mar 2014 11:55:33 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 14758 Message-ID: <531F320E.70605@metafoo.de> Date: Tue, 11 Mar 2014 16:55:58 +0100 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: Brian Austin CC: Nicolin Chen , broonie@kernel.org, Paul.Handrigan@cirrus.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, rob@landley.net, lgirdwood@gmail.com, grant.likely@linaro.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org Subject: Re: [PATCH v2] ASoC: cs42888: Add codec driver support References: <1394536791-8381-1-git-send-email-Guangyu.Chen@freescale.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/11/2014 04:41 PM, Brian Austin wrote: > > On Tue, 11 Mar 2014, Nicolin Chen wrote: > >> This patch adds support for the Cirrus Logic CS42888 Audio CODEC that >> has four 24-bit A/D and eight 24-bit D/A converters. >> >> [ CS42888 supports both I2C and SPI control ports. As initial patch, >> this patch only adds the support for I2C. ] >> >> Signed-off-by: Nicolin Chen >> --- > So WRT the CS42888, this is one device in a series of 2 devices that are > register compatible with the only difference being that the CS42488 has 2 > extra ADC's. Same die and same DeviceID. > > Would it make more sense to submit the driver with the extra ADC's to make > it feature complete for both devices? Wouldn't be odd to have 2 drivers that > do the same for 98% of the code. This should be in one driver. But support for the second device can always be added in a follow up patch. - Lars