public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@linux.intel.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andy Lutomirski <luto@amacapital.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Stefani Seibold <stefani@seibold.net>,
	the arch/x86 maintainers <x86@kernel.org>,
	Dave Jones <davej@redhat.com>,
	Martin Runge <Martin.Runge@rohde-schwarz.com>,
	Andreas Brief <Andreas.Brief@rohde-schwarz.com>
Subject: Re: [PATCH v2] x86: Remove compat vdso support
Date: Tue, 11 Mar 2014 09:42:42 -0700	[thread overview]
Message-ID: <531F3D02.30706@linux.intel.com> (raw)
In-Reply-To: <CA+55aFxmkBnwDfKhX7h1qoJ3emD=+ugc3OLNDH79a1kGu7He1Q@mail.gmail.com>

On 03/11/2014 09:30 AM, Linus Torvalds wrote:
> 
> No, the trivial solution is to stop adding crap to it.
> 
> And no, "just reserve a little more space for it" is neither trivial
> nor a good idea. The fixed VDSO address is very much at the top of the
> address space, so you can't allocate more space for it unless you do
> one of
> 
>  (a) make it non-contiguous
>  (b) get rid of the hole that is the very last page
>  (c) mess with the vsyscall pages and make it contiguous "backwards"
> 
> all of which sound like *horrible* ideas. Certainly not "trivial solution".
> 
> No, the trivial solution is to not mess with that legacy page at all.
> 
> Why is *that* trivial solution not on the table? Why the heck are
> people hell-bent on changing this stupid legacy page around?
> 
> I find this whole thread very annoying. We shouldn't care about
> x86-32, and certainly not from a performance angle - we should
> consider it a "it's done, don't touch it" issue.
> 

Andy actually did the research, and found that even the legacy VDSO
doesn't have to live at any one particular address, it just has to live
at the address it is linked at.  So we can move it just fine, but we
have to change the link address to match.

That gives us a lot more maneuvering room than saying it has to be at
one specific address.

	-hpa



  parent reply	other threads:[~2014-03-11 16:47 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-11  1:03 [PATCH v2] x86: Remove compat vdso support Andy Lutomirski
2014-03-11  1:39 ` Linus Torvalds
2014-03-11  2:37   ` Andy Lutomirski
2014-03-11  3:09     ` Linus Torvalds
2014-03-11  4:10       ` Andy Lutomirski
2014-03-11  8:37         ` Ingo Molnar
2014-03-11  9:36         ` Linus Torvalds
2014-03-11 14:53           ` Andy Lutomirski
2014-03-11 15:30             ` Linus Torvalds
2014-03-11 16:14               ` H. Peter Anvin
2014-03-11 16:30                 ` Linus Torvalds
2014-03-11 16:42                   ` Andy Lutomirski
2014-03-11 16:42                   ` H. Peter Anvin [this message]
2014-03-11 16:45                     ` Andy Lutomirski
2014-03-11 16:50                       ` Andy Lutomirski
2014-03-11 16:52                         ` H. Peter Anvin
2014-03-11 17:09                         ` Linus Torvalds
2014-03-11 17:14                           ` H. Peter Anvin
2014-03-11 17:16                           ` Andy Lutomirski
2014-03-12  8:30                           ` Stefani Seibold
2014-03-12 14:41                             ` Linus Torvalds
2014-03-12 15:46                               ` Linus Torvalds
2014-03-12 16:04                                 ` Linus Torvalds
2014-03-12 16:18                                   ` Brian Gerst
2014-03-12 16:18                                 ` Andy Lutomirski
2014-03-12 19:41                                 ` Linus Torvalds
2014-03-12 20:52                                   ` Andy Lutomirski
2014-03-12 21:37                                   ` H. Peter Anvin
2014-03-12 21:45                                     ` Andy Lutomirski
2014-03-12 21:46                                     ` Linus Torvalds
2014-03-12 21:49                                       ` Andy Lutomirski
2014-03-12 23:06                                         ` H. Peter Anvin
2014-03-12 23:43                                           ` Andy Lutomirski
2014-03-12 23:46                                             ` H. Peter Anvin
2014-03-13 16:23                                   ` Thomas Gleixner
2014-03-12 13:55                           ` One Thousand Gnomes
2014-03-13  7:08                           ` George Spelvin
2014-03-11 17:03                       ` H. Peter Anvin
2014-03-11 17:07                       ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=531F3D02.30706@linux.intel.com \
    --to=hpa@linux.intel.com \
    --cc=Andreas.Brief@rohde-schwarz.com \
    --cc=Martin.Runge@rohde-schwarz.com \
    --cc=davej@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=stefani@seibold.net \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox