From: Nicolas Ferre <nicolas.ferre@atmel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>
Cc: stable <stable@vger.kernel.org>, <jjhiblot@traphandler.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <b.brezillon@overkiz.com>
Subject: Re: [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval
Date: Wed, 12 Mar 2014 15:57:48 +0100 [thread overview]
Message-ID: <532075EC.7060809@atmel.com> (raw)
In-Reply-To: <1392210209-22142-1-git-send-email-nicolas.ferre@atmel.com>
On 12/02/2014 14:03, Nicolas Ferre :
> From: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
>
> When using dt resources retrieval (interrupts and reg properties) there is
> no predefined order for these resources in the platform dev resource
> table. Also don't expect the number of resource to be always 2.
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
> Acked-by: Boris BREZILLON <b.brezillon@overkiz.com>
> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
> Cc: stable <stable@vger.kernel.org> # 3.4
Gentle ping, after having resent the patch itself.
> ---
> drivers/usb/gadget/at91_udc.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c
> index cea8c20a1425..1926925a52a9 100644
> --- a/drivers/usb/gadget/at91_udc.c
> +++ b/drivers/usb/gadget/at91_udc.c
> @@ -1709,16 +1709,6 @@ static int at91udc_probe(struct platform_device *pdev)
> return -ENODEV;
> }
>
> - if (pdev->num_resources != 2) {
> - DBG("invalid num_resources\n");
> - return -ENODEV;
> - }
> - if ((pdev->resource[0].flags != IORESOURCE_MEM)
> - || (pdev->resource[1].flags != IORESOURCE_IRQ)) {
> - DBG("invalid resource type\n");
> - return -ENODEV;
> - }
> -
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (!res)
> return -ENXIO;
>
--
Nicolas Ferre
next prev parent reply other threads:[~2014-03-12 14:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1390488102-8548-1-git-send-email-jjhiblot@traphandler.com>
2014-02-12 13:03 ` [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval Nicolas Ferre
2014-03-12 14:57 ` Nicolas Ferre [this message]
2014-03-12 15:31 ` Greg Kroah-Hartman
2014-03-12 16:28 ` Nicolas Ferre
2014-03-12 16:30 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532075EC.7060809@atmel.com \
--to=nicolas.ferre@atmel.com \
--cc=b.brezillon@overkiz.com \
--cc=gregkh@linuxfoundation.org \
--cc=jjhiblot@traphandler.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox