* [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval [not found] <1390488102-8548-1-git-send-email-jjhiblot@traphandler.com> @ 2014-02-12 13:03 ` Nicolas Ferre 2014-03-12 14:57 ` Nicolas Ferre 2014-03-12 16:30 ` Nicolas Ferre 1 sibling, 1 reply; 5+ messages in thread From: Nicolas Ferre @ 2014-02-12 13:03 UTC (permalink / raw) To: Greg Kroah-Hartman, linux-usb Cc: linux-arm-kernel, linux-kernel, jjhiblot, b.brezillon, stable From: Jean-Jacques Hiblot <jjhiblot@traphandler.com> When using dt resources retrieval (interrupts and reg properties) there is no predefined order for these resources in the platform dev resource table. Also don't expect the number of resource to be always 2. Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com> Acked-by: Boris BREZILLON <b.brezillon@overkiz.com> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> Cc: stable <stable@vger.kernel.org> # 3.4 --- drivers/usb/gadget/at91_udc.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c index cea8c20a1425..1926925a52a9 100644 --- a/drivers/usb/gadget/at91_udc.c +++ b/drivers/usb/gadget/at91_udc.c @@ -1709,16 +1709,6 @@ static int at91udc_probe(struct platform_device *pdev) return -ENODEV; } - if (pdev->num_resources != 2) { - DBG("invalid num_resources\n"); - return -ENODEV; - } - if ((pdev->resource[0].flags != IORESOURCE_MEM) - || (pdev->resource[1].flags != IORESOURCE_IRQ)) { - DBG("invalid resource type\n"); - return -ENODEV; - } - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!res) return -ENXIO; -- 1.8.2.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval 2014-02-12 13:03 ` [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval Nicolas Ferre @ 2014-03-12 14:57 ` Nicolas Ferre 2014-03-12 15:31 ` Greg Kroah-Hartman 0 siblings, 1 reply; 5+ messages in thread From: Nicolas Ferre @ 2014-03-12 14:57 UTC (permalink / raw) To: Greg Kroah-Hartman, linux-usb Cc: stable, jjhiblot, linux-kernel, linux-arm-kernel, b.brezillon On 12/02/2014 14:03, Nicolas Ferre : > From: Jean-Jacques Hiblot <jjhiblot@traphandler.com> > > When using dt resources retrieval (interrupts and reg properties) there is > no predefined order for these resources in the platform dev resource > table. Also don't expect the number of resource to be always 2. > > Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com> > Acked-by: Boris BREZILLON <b.brezillon@overkiz.com> > Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> > Cc: stable <stable@vger.kernel.org> # 3.4 Gentle ping, after having resent the patch itself. > --- > drivers/usb/gadget/at91_udc.c | 10 ---------- > 1 file changed, 10 deletions(-) > > diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c > index cea8c20a1425..1926925a52a9 100644 > --- a/drivers/usb/gadget/at91_udc.c > +++ b/drivers/usb/gadget/at91_udc.c > @@ -1709,16 +1709,6 @@ static int at91udc_probe(struct platform_device *pdev) > return -ENODEV; > } > > - if (pdev->num_resources != 2) { > - DBG("invalid num_resources\n"); > - return -ENODEV; > - } > - if ((pdev->resource[0].flags != IORESOURCE_MEM) > - || (pdev->resource[1].flags != IORESOURCE_IRQ)) { > - DBG("invalid resource type\n"); > - return -ENODEV; > - } > - > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > if (!res) > return -ENXIO; > -- Nicolas Ferre ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval 2014-03-12 14:57 ` Nicolas Ferre @ 2014-03-12 15:31 ` Greg Kroah-Hartman 2014-03-12 16:28 ` Nicolas Ferre 0 siblings, 1 reply; 5+ messages in thread From: Greg Kroah-Hartman @ 2014-03-12 15:31 UTC (permalink / raw) To: Nicolas Ferre Cc: linux-usb, stable, jjhiblot, linux-kernel, linux-arm-kernel, b.brezillon On Wed, Mar 12, 2014 at 03:57:48PM +0100, Nicolas Ferre wrote: > On 12/02/2014 14:03, Nicolas Ferre : > > From: Jean-Jacques Hiblot <jjhiblot@traphandler.com> > > > > When using dt resources retrieval (interrupts and reg properties) there is > > no predefined order for these resources in the platform dev resource > > table. Also don't expect the number of resource to be always 2. > > > > Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com> > > Acked-by: Boris BREZILLON <b.brezillon@overkiz.com> > > Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> > > Cc: stable <stable@vger.kernel.org> # 3.4 > > Gentle ping, after having resent the patch itself. It helps if you send it to the correct maintainer, remember, scripts/get_maintainer.pl is your friend... ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval 2014-03-12 15:31 ` Greg Kroah-Hartman @ 2014-03-12 16:28 ` Nicolas Ferre 0 siblings, 0 replies; 5+ messages in thread From: Nicolas Ferre @ 2014-03-12 16:28 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: linux-usb, stable, jjhiblot, linux-kernel, linux-arm-kernel, b.brezillon On 12/03/2014 16:31, Greg Kroah-Hartman : > On Wed, Mar 12, 2014 at 03:57:48PM +0100, Nicolas Ferre wrote: >> On 12/02/2014 14:03, Nicolas Ferre : >>> From: Jean-Jacques Hiblot <jjhiblot@traphandler.com> >>> >>> When using dt resources retrieval (interrupts and reg properties) there is >>> no predefined order for these resources in the platform dev resource >>> table. Also don't expect the number of resource to be always 2. >>> >>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com> >>> Acked-by: Boris BREZILLON <b.brezillon@overkiz.com> >>> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> >>> Cc: stable <stable@vger.kernel.org> # 3.4 >> >> Gentle ping, after having resent the patch itself. > > It helps if you send it to the correct maintainer, remember, > scripts/get_maintainer.pl is your friend... Indeed. I add Felipe to my next attempt: sorry for the (repeated) noise. Bye, -- Nicolas Ferre ^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval [not found] <1390488102-8548-1-git-send-email-jjhiblot@traphandler.com> 2014-02-12 13:03 ` [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval Nicolas Ferre @ 2014-03-12 16:30 ` Nicolas Ferre 1 sibling, 0 replies; 5+ messages in thread From: Nicolas Ferre @ 2014-03-12 16:30 UTC (permalink / raw) To: Greg Kroah-Hartman, linux-usb, balbi Cc: linux-arm-kernel, linux-kernel, jjhiblot, b.brezillon, stable From: Jean-Jacques Hiblot <jjhiblot@traphandler.com> When using dt resources retrieval (interrupts and reg properties) there is no predefined order for these resources in the platform dev resource table. Also don't expect the number of resource to be always 2. Signed-off-by: Jean-Jacques Hiblot <jjhiblot@traphandler.com> Acked-by: Boris BREZILLON <b.brezillon@overkiz.com> Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com> Cc: stable <stable@vger.kernel.org> # 3.4 --- drivers/usb/gadget/at91_udc.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/usb/gadget/at91_udc.c b/drivers/usb/gadget/at91_udc.c index cea8c20a1425..1926925a52a9 100644 --- a/drivers/usb/gadget/at91_udc.c +++ b/drivers/usb/gadget/at91_udc.c @@ -1709,16 +1709,6 @@ static int at91udc_probe(struct platform_device *pdev) return -ENODEV; } - if (pdev->num_resources != 2) { - DBG("invalid num_resources\n"); - return -ENODEV; - } - if ((pdev->resource[0].flags != IORESOURCE_MEM) - || (pdev->resource[1].flags != IORESOURCE_IRQ)) { - DBG("invalid resource type\n"); - return -ENODEV; - } - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); if (!res) return -ENXIO; -- 1.8.2.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-03-12 16:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1390488102-8548-1-git-send-email-jjhiblot@traphandler.com>
2014-02-12 13:03 ` [PATCH RESEND] usb: at91-udc: fix irq and iomem resource retrieval Nicolas Ferre
2014-03-12 14:57 ` Nicolas Ferre
2014-03-12 15:31 ` Greg Kroah-Hartman
2014-03-12 16:28 ` Nicolas Ferre
2014-03-12 16:30 ` Nicolas Ferre
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox