public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Lutomirski <luto@amacapital.net>
To: Vivek Goyal <vgoyal@redhat.com>,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	netdev@vger.kernel.org, davem@davemloft.net, tj@kernel.org
Cc: ssorce@redhat.com, jkaluza@redhat.com, lpoetter@redhat.com,
	kay@redhat.com
Subject: Re: [PATCH 0/2][V2] net: Implement SO_PEERCGROUP to get cgroup of peer
Date: Wed, 12 Mar 2014 13:56:28 -0700	[thread overview]
Message-ID: <5320C9FC.6070301@amacapital.net> (raw)
In-Reply-To: <1394657163-7472-1-git-send-email-vgoyal@redhat.com>

On 03/12/2014 01:46 PM, Vivek Goyal wrote:
> Hi,
> 
> This is V2 of patches. Fixed the function format issue and also I was using
> CONFIG_CGROUP instead of CONFIG_CGROUPS. That led to crash at boot. Fixed that.
> 
> Some applications like sssd want to know the cgroup of connected peer over
> unix stream socket. They want to use this information to map the cgroup to 
> the container client belongs to and then decide what kind of policies apply
> on the container.
> 

Can you explain what the use case is?

My a priori opinion is that this is a terrible idea.  cgroups are a
nasty interface, and letting knowledge of cgroups leak into the programs
that live in the groups (as opposed to the cgroup manager) seems like a
huge mistake to me.

If you want to know where in the process hierarchy a message sender is,
add *that* and figure out how to fix the races (it shouldn't be that hard).

--Andy

  parent reply	other threads:[~2014-03-12 20:56 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-12 20:46 [PATCH 0/2][V2] net: Implement SO_PEERCGROUP to get cgroup of peer Vivek Goyal
2014-03-12 20:46 ` [PATCH 1/2] cgroup: Provide empty definition of task_cgroup_path() Vivek Goyal
2014-03-12 20:46 ` [PATCH 2/2] net: Implement SO_PEERCGROUP Vivek Goyal
2014-03-12 20:58   ` Cong Wang
2014-03-13 13:48     ` Vivek Goyal
2014-03-12 21:00   ` Andy Lutomirski
2014-03-12 21:12     ` Andy Lutomirski
2014-03-12 21:16       ` Simo Sorce
2014-03-12 21:19         ` Andy Lutomirski
2014-03-13  1:17           ` Simo Sorce
2014-03-13  1:21             ` Andy Lutomirski
2014-03-13  1:43               ` Simo Sorce
2014-03-13  2:12                 ` Andy Lutomirski
2014-03-13 14:27                   ` Vivek Goyal
2014-03-14 23:54                     ` Eric W. Biederman
2014-03-13 17:51                   ` Simo Sorce
2014-03-13 17:55                     ` Andy Lutomirski
2014-03-13 17:57                       ` Simo Sorce
2014-03-13 18:03                         ` Andy Lutomirski
2014-03-13 17:58                       ` Simo Sorce
2014-03-13 18:01                         ` Andy Lutomirski
2014-03-13 18:05                         ` Tim Hockin
2014-03-13 19:53                       ` Vivek Goyal
2014-03-13 19:58                         ` Andy Lutomirski
2014-03-13 20:06                           ` Vivek Goyal
2014-03-13 20:17                             ` Vivek Goyal
2014-03-13 20:19                               ` Vivek Goyal
2014-03-13 21:21                             ` Andy Lutomirski
2014-03-14 23:49                             ` Eric W. Biederman
2014-03-13 18:02                     ` Vivek Goyal
2014-03-13 14:14       ` Vivek Goyal
2014-03-13 14:55         ` Simo Sorce
2014-03-13 15:00           ` Vivek Goyal
2014-03-13 16:33             ` Simo Sorce
2014-03-13 17:25               ` Andy Lutomirski
2014-03-13 17:55                 ` Simo Sorce
2014-03-13 17:56                 ` Tim Hockin
2014-03-12 20:56 ` Andy Lutomirski [this message]
2014-03-12 20:59   ` [PATCH 0/2][V2] net: Implement SO_PEERCGROUP to get cgroup of peer Simo Sorce
2014-03-12 21:09     ` Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5320C9FC.6070301@amacapital.net \
    --to=luto@amacapital.net \
    --cc=cgroups@vger.kernel.org \
    --cc=davem@davemloft.net \
    --cc=jkaluza@redhat.com \
    --cc=kay@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lpoetter@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=ssorce@redhat.com \
    --cc=tj@kernel.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox