Re: [PATCH v2] x86: Remove compat vdso support

Thomas Gleixner
2014-03-13T16:23:27Z

On Wed, 12 Mar 2014, Linus Torvalds wrote:
> On Wed, Mar 12, 2014 at 8:46 AM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > - do *not* add the HPET/VVAR page games to the legacy case. Get rid
> > of the remap_pfn_pages() games entirely.
>
> .. actually, another approach would be to do the HPET/VVAR page games,
> but make them non-legacy.
>
> The reason I hate seeing those remap_pfn_range() things is because
> it's nasty code for a legacy case that I think shouldn't have new code
> written for it, especially when it won't get testing by developers.
>
> So my reaction was "don't do that".
>
> But people pointing out that we can't do what x86-64 does made me
> think: we could avoid the whole "nasty code for a legacy case" by
> making it the *non*-legacy case. We could get rid of the fixmap
> HPET/VVAR entirely - on x86-64 (which can use those addresses) a
> PC-relative addressing is probably actually better anyway, so mapping
> them together with the vdso code shouldn't hurt.
>
> That would remove my objections to doing all this stuff for a case
> that developers won't see and use (the whole "It's dead, Jim"
> objection) . And it would unify the 32-bit and 64-bit cases.
>
> Together with Andy's "remove legacy 32-bit fixmap vdso", I'd feel that
> this is actually an _improvement_ to the current situation.
>
> Would something like that be more acceptable to everybody?

Definitely yes.

Thanks,

tglx