Re: [PATCH V2] Change ACPI IPMI support to "default y"

[Corey Minyard <minyard@acm.org>]

On 03/13/2014 03:38 AM, Pavel Machek wrote:
> On Thu 2014-03-13 07:24:36, Matthew Garrett wrote:
>> On Thu, 2014-03-13 at 08:22 +0100, Pavel Machek wrote:
>>> On Wed 2014-03-12 23:22:49, Matthew Garrett wrote:
>>>> No. The power meter driver knows nothing about IPMI. It makes no IPMI
>>>> calls. There's no requirement that a vendor implement it via IPMI.
>>> Yet you claim that IMPI is needed for that, and that's why you made
>>> IMPI default.
>> I claim that the ACPI spec defines the behaviour of IPMI operation
>> regions, and so we should default IPMI to Y in order to (by default)
>> implement the ACPI spec.
>>
>>> So ... do we need dmi-based blacklist?
>> I don't see why.
> Your reasoning for default y was that "power meter depends on
> this". Then, claim that "power meter does not officially depend on it"
> so it would be wrong to have a dependency.

I believe the correct statement is "On some systems power meter depends
on it".

>
> Defaults are not right solution; system should still work if I select
> non-default settings. Which you claim is not a case, but you don't see
> why you should fix it.

If something is implemented using IPMI, then IPMI has to be there to
use it.  Matthew's statement was:

For example, if you load the ACPI power meter driver before you've
installed the ACPI IPMI driver you'll typically get failures (most
vendors implement it via IPMI).

Other things besides the power meter can be implemented using IPMI, it's
up to the vendor.  How will those things work if IPMI is not available?

-corey