From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752823AbaCMNsJ (ORCPT ); Thu, 13 Mar 2014 09:48:09 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:43250 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751061AbaCMNsI (ORCPT ); Thu, 13 Mar 2014 09:48:08 -0400 Message-ID: <5321B701.5050004@ti.com> Date: Thu, 13 Mar 2014 21:47:45 +0800 From: Santosh Shilimkar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Kishon Vijay Abraham I , "Balbi, Felipe" CC: "Strashko, Grygorii" , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY References: <1394709073-1980-1-git-send-email-grygorii.strashko@ti.com> <5321B4B4.9010806@ti.com> <5321B5FA.2030806@ti.com> In-Reply-To: <5321B5FA.2030806@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 13 March 2014 09:43 PM, Kishon Vijay Abraham I wrote: > Hi Santosh, > > On Thursday 13 March 2014 07:07 PM, Santosh Shilimkar wrote: >> On Thursday 13 March 2014 07:11 PM, Strashko, Grygorii wrote: >>> This fixes a regression on Keystone 2 platforms caused by patch >>> 57303488cd37da58263e842de134dc65f7c626d5 >>> "usb: dwc3: adapt dwc3 core to use Generic PHY Framework" which adds >>> optional support of generic phy in DWC3 core. >>> >>> On Keystone 2 platforms the USB is not working now because >>> CONFIG_GENERIC_PHY isn't set and, as result, Generic PHY APIs stubs >>> return -ENOSYS always. The log shows: >>> dwc3 2690000.dwc3: failed to initialize core >>> dwc3: probe of 2690000.dwc3 failed with error -38 >>> >>> Hence, fix it by making NULL a valid phy reference in Generic PHY >>> APIs stubs in the same way as it was done by the patch >>> 04c2facad8fee66c981a51852806d8923336f362 "drivers: phy: Make NULL >>> a valid phy reference". >>> >>> CC: Kishon Vijay Abraham I >>> CC: Felipe Balbi >>> CC: Santosh Shilimkar >>> Signed-off-by: Grygorii Strashko >>> --- >> This fixes the regression seen in Linux next and patch seems >> reasonable to me. >> Acked-by: Santosh Shilimkar >> >> Felipe, Kishon, >> Can you guys pick this fix if you are ok by it. Thanks > > I've already given a PULL request to Greg for 3.15. Is it ok to take this in -rc cycle? > Am not sure because this is breaking the existing functionality. May be you can request Greg to pull this fix as well. Regards, Santosh