From: Jens Axboe <axboe@kernel.dk>
To: Sam Bradshaw <sbradshaw@micron.com>
Cc: linux-kernel@vger.kernel.org,
Felipe Franciosi <felipe@paradoxo.org>,
david.vrabel@citrix.com,
"Asai Thambi Samymuthu Pattrayasamy (asamymuthupa)"
<asamymuthupa@micron.com>
Subject: Re: [PATCH] mtip32xx: mtip_async_complete() bug fixes
Date: Thu, 13 Mar 2014 15:59:42 -0600 [thread overview]
Message-ID: <53222A4E.70006@kernel.dk> (raw)
In-Reply-To: <5322242A.6080901@micron.com>
On 03/13/2014 03:33 PM, Sam Bradshaw wrote:
> On 03/13/2014 02:02 PM, Jens Axboe wrote:
>> On 03/13/2014 03:09 PM, Sam Bradshaw wrote:
>>> This patch fixes 2 issues in the fast completion path:
>>> 1) Possible double completions / double dma_unmap_sg() calls due to lack
>>> of atomicity in the check and subsequent dereference of the upper layer
>>> callback function. Fixed with cmpxchg before unmap and callback.
>>> 2) Regression in unaligned IO constraining workaround for p420m devices.
>>> Fixed by checking if IO is unaligned and using proper semaphore if so.
>>
>> Sam, what is this patch against? It doesn't apply to -rc6 and it doesn't
>> apply to for-3.15/drivers (the latter would be preferred/required). It
>> also seems to have line break issues.
>>
>
> It's against for-3.15/drivers. Sorry about the breaks; if I remove them
> does it apply cleanly?
Yep, this one is much better. Thanks!
--
Jens Axboe
prev parent reply other threads:[~2014-03-13 21:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 21:09 [PATCH] mtip32xx: mtip_async_complete() bug fixes Sam Bradshaw
2014-03-13 21:02 ` Jens Axboe
2014-03-13 21:33 ` Sam Bradshaw
2014-03-13 21:59 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53222A4E.70006@kernel.dk \
--to=axboe@kernel.dk \
--cc=asamymuthupa@micron.com \
--cc=david.vrabel@citrix.com \
--cc=felipe@paradoxo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sbradshaw@micron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox