From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755044AbaCMXIA (ORCPT ); Thu, 13 Mar 2014 19:08:00 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:27974 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753103AbaCMXH7 (ORCPT ); Thu, 13 Mar 2014 19:07:59 -0400 Message-ID: <53223A4A.7070408@oracle.com> Date: Thu, 13 Mar 2014 19:07:54 -0400 From: Sasha Levin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Linus Torvalds CC: Linux Kernel Mailing List Subject: Re: [RFC] improve_stack: make stack dump output useful again References: <1393114777-21588-1-git-send-email-sasha.levin@oracle.com> <5321CBDA.1060705@oracle.com> <53222F1A.8090205@oracle.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: acsinet21.oracle.com [141.146.126.237] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/13/2014 06:59 PM, Linus Torvalds wrote: > On Thu, Mar 13, 2014 at 3:20 PM, Sasha Levin wrote: >> >> I'll fix it up and re-send this patch. > > The problem (as you will find out) is that "addr2line" doesn't take > symbolic names. > > So either addr2line needs to be improved (which really would be a good > idea regardless), or your script needs to use "nm" or "gdb" or > something to first translate the symbol+off into a hex number (which > will not match the kernel-provided hex number when base randomization > is in effect, but it will match the pre-randomized data in the vmlinux > file, so then addr2line would work). I figured that I'll just read it from System.map (and do the math when adding the offset). That should work, right? Thanks, Sasha